Badger-Finance / badger-avatars

4 stars 1 forks source link

Feat/security review v0.1.1 #31

Closed petrovska-petro closed 1 year ago

petrovska-petro commented 1 year ago

Tackles comments from notes, specifically:

[WP-M1], [WP-M2], [WP-G5], [WP-G6] and [WP-G7]

Reference to comments on the DD, ref

codecov[bot] commented 1 year ago

Codecov Report

Merging #31 (e539201) into main (c245192) will decrease coverage by 0.26%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   95.85%   95.59%   -0.26%     
==========================================
  Files           8        8              
  Lines         651      658       +7     
  Branches       94      101       +7     
==========================================
+ Hits          624      629       +5     
- Misses          9       10       +1     
- Partials       18       19       +1     
Impacted Files Coverage Δ
src/aura/AuraAvatarMultiToken.sol 98.18% <75.00%> (-0.90%) :arrow_down:
src/convex/ConvexAvatarMultiToken.sol 97.62% <100.00%> (+0.03%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gosuto-inzasheru commented 1 year ago

going to let @GalloDaSballo give second review here