Badger-Finance / badger-strategies

5 stars 1 forks source link

[MAINNET]: Badger/wBTC Curve LP #47

Closed sajanrajdev closed 2 years ago

sajanrajdev commented 2 years ago

Strategy Review

Description

Deploy an StrategyConvexStakingOptimizer vault for the newly incentivized BADGER/wBTC

Code Link

https://github.com/Badger-Finance/strategy-convex-staking-optimizer/pull/26

Deployed Contract (If present)

Review By

Review by Security Board

*Ongoing

Test Checks (screen shot of all test passing)

image

Harvest example: image

sajanrajdev commented 2 years ago

Strat latest Logic: 0x8827D01b4E434138F2cE0Acc6cDA0A2c228EdA1f

Controller: 0xa54d8a596B4022CC4436b692C8ea0E342405eB6e

BADGER/wBTC CRV LP Want: 0x137469B55D1f15651BA46A89D0588e97dD0B6562 Vault: 0xeC1c717A3b02582A4Aa2275260C583095536b613 Strategy: 0x1905FD2D2D09792eE058C2b46a05F11630a1EcA1

Txs: Controller init: https://etherscan.io/tx/0x1e97a9c509f9f7d0c0eb2c862b7ad7923376dcba537905313106aea958650f4c Vault init: https://etherscan.io/tx/0x924aa08c3097474d8029304c6aee279dd816fd63740f4f941d9b5aa1065395a0 Strat init: https://etherscan.io/tx/0x6e8de71d408bee61fd72bc6e575fc8d5def4ce35e5bdb6d3e4afae14262b1696

Unpause: https://etherscan.io/tx/0xbd0404011ea299c5f948dce43e6ef4c5adabbf48a923f335a8201ba81d545a03

Wireup: https://etherscan.io/tx/0x5b4f3f6a138adf5af7bc576271b25039a448dbfe21b8bf9b114023d1a18782ab https://etherscan.io/tx/0xb19da75e6406753fc22f6fb8fe04425b5cae41a21c895a59b6aeddbbf3a63bde https://etherscan.io/tx/0xe72659527dc12c3e8b29d0323a8e9f610be349d78f5b78d4b66e7a07176f65db

sajanrajdev commented 2 years ago

Added to the registry: https://etherscan.io/tx/0xa8c52cb19b9793e0d5600c6b91eda72f6efdba7dcbdac89455e1c70b0350c2b1

sajanrajdev commented 2 years ago

Approve contract access tx (on the bcvxCRV for the strat) has been added to the devMultisig at nonce 1028: image

sajanrajdev commented 2 years ago

Test function calls: Earn:

Harvests:

sajanrajdev commented 2 years ago

Approved Contract Access to multisigs; Trops: https://etherscan.io/tx/0x03e69ad95d232277ef26a45ebe9753f2e9fd8a92ff9325c96ec26539f6c80356 TechOps: https://etherscan.io/tx/0x4b05153b1d9a58e8dd65468981229c74ac6a0c792d5a679226d801d2ebb0845a devMulti: https://etherscan.io/tx/0x970b3cdd31f07cad40fac93c1fd51e247fd6bcb4464a20db4e3c44b23a96c6ed vault: https://etherscan.io/tx/0xf1954d47e394c8d2dba3dceea6bb37604aa0128f2785fe338dff719fec101253

sajanrajdev commented 2 years ago

Contract delegations:

ProxyAdmin delegations: Vault: https://etherscan.io/tx/0x7a762757f5bc2915f1384e7d3264d4757cf958dca2c56634647f16de514bca9f Strat: https://etherscan.io/tx/0x2f764160e884b15c498e012cf830a3d93d0a298fd11c38ed06181df41faa1073 Controller already has the devProxyAdmin: 0x20dce41acca85e8222d6861aa6d23b6c941777bf

>>> web3.eth.getStorageAt("0xeC1c717A3b02582A4Aa2275260C583095536b613", "0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d610
3").hex()
'0x20dce41acca85e8222d6861aa6d23b6c941777bf'
>>> web3.eth.getStorageAt("0x1905FD2D2D09792eE058C2b46a05F11630a1EcA1", "0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d610
3").hex()
'0x20dce41acca85e8222d6861aa6d23b6c941777bf'
>>> web3.eth.getStorageAt("0xa54d8a596B4022CC4436b692C8ea0E342405eB6e", "0xb53127684a568b3173ae13b9f8a6016e243e63b6e8ee1178d6a717850b5d610
3").hex()
'0x20dce41acca85e8222d6861aa6d23b6c941777bf'
sajanrajdev commented 2 years ago

Governance delegations:

Vault: https://etherscan.io/tx/0xd39018f7fdc1bd220bf249804e436a52505223fc58dc948ff29277370de58464 Strategy: https://etherscan.io/tx/0x1cb5b48fbe9eeb3735752acd4a487dd7fe6aaa2064b45a97a35017ec9453a561 Controller: https://etherscan.io/tx/0xe786fd15aa7c2e66f94f8ed4d798f104c52fb3d005fb0eb3a15dc0e2cd0b5246

sajanrajdev commented 2 years ago

Vault launched: image