[CITADEL] CTDL/wBTC Convex Optimizer with Split distribution

[GalloDaSballo]

Strategy Review

https://docs.google.com/document/d/1surKSrEyEE_2aq8_Rwadvo_JrwuoYJHsm34YxG4ggcU/edit

NOTE: See doc for split (cannot just copy paste the strat!!)

Description

Plaintext logic. Can be a link to README or other doc.

Code Link

Commit / Hash / Repo should be known from this.

Due Diligence Document (Link, but could also just be a .md file in repo)

This document evaluates the protocols that are interacted with as strategy positions.

Deployed Contract (If present)

Review By

• Ongoing:
• Completed:

Review by Security Board

• Not started / ongoing / completed

Test Checks (screen shot of all test passing)

[GalloDaSballo]

Due before Citadel LP launch

[sajanrajdev]

Code is ready for review: https://github.com/sajanrajdev/strategy-convex-staking-citadel-v1.5/tree/main

This is the first version of the strategy that:

• Stakes CTDL/wBTC Lp on Convex (Tests with BADGER/wBTC while pool is deployed)
• Harvests CRV and CVX
• Allows governance to set a customizable split for the harvest (autocompound, emit wBTC to xCTDL locker, or emit wBTC to CTDL Treasury).
• Autocompounds and/or distributes according to the above split upon harvest.

NOTES:

• Code is written so that only governance can change the strategy split and destination parameters. If we desire to give both Badger and Citadel these rights, we could set the Citadel multisig as the strategist and make the functions _onlyGovernanceOrStrategist(). For now, the assumption is that the Citadel multisig will hold the governance control.
• The intention is as well to handle the ACL with a guestlist contract with a random proof and with the citadel depositor whitelisted manually. It is intended to do so in order to avoid modifying the vault contract. Citadel governance should hold the owernship of this guestlist.
• The Strategy requires for it to be approved as a wBTC distributor on the xCitadel Locker for emissions to this to work. Can be done so as from confest.py:

  xCitadelLocker.approveRewardDistributor(
      strategy.wbtc(),
      strategy.address,
      True,
      {"from": governance}
  )

Reviewers:

• [ ] @GalloDaSballo
• [ ] @shuklaayush
• [ ] @btcookies
• [ ] @axejintao

All tests are passing:

[btcookies]

@sajanrajdev could we not set up an ACL contract similar to what we do for the keepers to handle having multiple governance wallets? Or do you think having strategist and governance is a sufficient solution?

[sajanrajdev]

@btcookies, that is always an option but I really don't see the need for it. TheVault and BaseStrategy contracts already offer the governance and strategist with the necessary modifiers for access control (and it is not ideal to modify these contracts and they are fully audited). Adding another layer of ACL to these would represent an overkill imo given that we will only have Badger and Citadel interacting with these.

I think it all comes down to who will be owning and maintaining these strats. Maybe @dapp-whisperer can give us more insights there. If we need more than multi with permissions, then I could implement an ACL.

[GalloDaSballo]

Closing in lack of feedback