Fee config tests and Strategy fixes

sajanrajdev commented 2 years ago

This PR closes #17 and #20

Added test to assert that the multiple fee configuration options work as expected
Fixed bcvxCRV fee events: currently emitting fee events on the cvxCRV value instead of the bcvxCRV.
Fixed if statement that checks for cvxCRV harvested before the CRV is processed into cvxCRV - Currently not all strats receive cvxCRV directly upon harvest which causes the fee processing/emission to only occur every other harvest. Having the cvxCRV balance check after the CRV is processed into cvxCRV allows for this token to be processed regardless of if there's any cvxCRV to begin with.

sajanrajdev commented 2 years ago

Will add the python linting fixes in another PR to avoid obfuscating the changes here.

sajanrajdev commented 2 years ago

Fixed fee event token assertion on the tests/test_custom.py::test_are_you_trying test.

All tests are passing, ran for renCrv:

Badger-Finance / strategy-convex-staking-optimizer