BadgerCode / tttdamagelogs

Damagelogs and RDM Manager for Trouble in Terrorist Town (a Garry's Mod gamemode)
GNU General Public License v3.0
20 stars 23 forks source link

SAM bugs #51

Open CrypticNetwork opened 3 years ago

CrypticNetwork commented 3 years ago

When setting slays you cannot overwrite the slay amount unless you set slays to 0 or remove the slays. If you try to overwrite the amount of slays with a different amount it produces an error: https://i.imgur.com/eqgdhYQ.png

If you try setting the amount of slays to the same amount it shows it as nill: https://i.imgur.com/lyPoVos.png

When using the remove 1 autoslay button in the rdm manager it doesn't seem to work. Instead it shows the format in chat: https://i.imgur.com/RAz3jMF.png

The cslayid command never properly works and only produces this: https://i.imgur.com/3RKVRHa.png

When checking slays with csay it shows the string "jails" for some odd reason. Also I believe SAM uses the players name who called the command instead of you so the string would be "has" instead of "have" https://i.imgur.com/aQrkhnx.png

BadgerCode commented 3 years ago

Hey! Thanks for raising this.

I will need to look into this.

dok441 commented 3 years ago

There is such a problem, I confirm.

BadgerCode commented 3 years ago

This is a little difficult for me to test as I do not own the SAM admin system - https://www.gmodstore.com/market/view/sam

Is there any documentation which details the parameters of the following console commands:

-- Slay a player immediately
sam slay <player_name?>

-- Send a message to a player
sam pm <player_name?> <message>

-- Automatically slay a player at the start of the round for X rounds (number_of_slays)
-- Does sam have auto-slay?
-- And does this add the number of slays, or set their remaining slays to this number
sam aslayid <player_steamID?> <number_of_slays>

-- Automatically jail a player for X minutes (duration_in_minutes)
-- Does SAM have jail?
-- If so, how do you unjail a player?
sam ajailid <player_steamID?> <duration_in_minutes?>

-- ban a player
sam ban <player_name?> <duration_in_minutes?> <reason>

-- ban a player by steamID
sam banid <steam_id> <duration_in_minutes?> <reason>
dok441 commented 3 years ago

https://github.com/Srlion/SAM-Docs/wiki/Player-Functions Only such documentation.

BadgerCode commented 3 years ago

That documentation doesn't talk about the console commands unfortunately 😦 We might be able to use some of those functions instead of the console commands.

If someone with the SAM admin system could try the console commands listed below in their in-game console, it might provide details for the arguments.

E.g. image

sam slay
sam pm
sam aslayid
sam ajailid
sam ban
sam banid

If any of these commands don't exist, could someone try to find a command which does something similar.

dok441 commented 3 years ago

https://pastebin.com/WatFPH4Z

SenseiHiraku commented 3 years ago

If you try setting the amount of slays to the same amount it shows it as nill: https://i.imgur.com/lyPoVos.png

This issue should be fixed in my pull request https://github.com/BadgerCode/tttdamagelogs/pull/63/commits/41698181a1f3b4586649eeddc57f8de5701b2bd2 . It seems, that the slay amount wasn't properly implemented in the chat message.

BadgerCode commented 3 years ago

An update has been released that should fix the below issues. New version - https://github.com/BadgerCode/tttdamagelogs/releases/tag/v3.4.2

Could you update your copy of the damagelogs and test it again to see if these issues remain?

When setting slays you cannot overwrite the slay amount unless you set slays to 0 or remove the slays. If you try to overwrite the amount of slays with a different amount it produces an error: https://i.imgur.com/eqgdhYQ.png

If you try setting the amount of slays to the same amount it shows it as nill: https://i.imgur.com/lyPoVos.png

When using the remove 1 autoslay button in the rdm manager it doesn't seem to work. Instead it shows the format in chat: https://i.imgur.com/RAz3jMF.png