Why:
I think this app is great and will be very useful for growing BeatSage community, but it could get a bit more readable, so it can be maintained and expanded by author and open source community in the future. The changes proposed here might feel slightly huge at first, but I think it might be a good step in the right direction.
What this PR does:
Divides code structure into:
Views (containing xaml windows and xaml.cs logic files)
Models (classes)
Services (mostly in form of static helpers as of now)
This code structure relates more to typical MVVM architecture used in WPF apps.
Extracts Download and DownloadManager classes (Models) into separate files
Adds following services:
YoutubeService (responsibility of Importing and Retrieving playlists, could still be expanded)
CustomLevelService (responsibility of requesting level creation by CreateFromFile, CreateWithLocalMP3Download and Create methods)
The steps above mean that xaml.cs files are now much less responsible for managing business logic and contain mostly methods related to click events.
Removes unnecessary usings and sorts them alphabetically, removes some redundant values.
Updates .Net Framework to v.4.7.2 and implements latest PropertyChanged.Fody, which helped simplifying binding syntax.
What this does not do:
It does not interfere with methods logic of original author.
It does not divide existing methods into smaller ones.
It does not embrace real MVVM (lack of ViewModels, binding to Models)
It does not repair bug related to removing list element when it's processed.
What I think could be further improved:
Binding settings checkboxes state into boolean fields (that's where ViewModel could be useful) to avoid multiple checks against the settings in AddDownloadWindow.xaml.cs
Previous settings could be then parsed in separate service as a List and checked in more robust way.
Why: I think this app is great and will be very useful for growing BeatSage community, but it could get a bit more readable, so it can be maintained and expanded by author and open source community in the future. The changes proposed here might feel slightly huge at first, but I think it might be a good step in the right direction.
What this PR does:
Divides code structure into:
Extracts Download and DownloadManager classes (Models) into separate files
Adds following services:
The steps above mean that xaml.cs files are now much less responsible for managing business logic and contain mostly methods related to click events.
Removes unnecessary usings and sorts them alphabetically, removes some redundant values.
Updates .Net Framework to v.4.7.2 and implements latest PropertyChanged.Fody, which helped simplifying binding syntax.
What this does not do:
What I think could be further improved:
Tested functionality with playlists, multiple links, various settings and paths.
Feel free to squash merge if you like the changes or discuss them further.