search

Badgerati / Fudge

Fudge is a PowerShell tool to help manage software packages via Chocolatey for specific development projects. Think NPM and Bower, but for Chocolatey
MIT License
21 stars 3 forks source link

Tweaks to improve usage of copied Fudge #73

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

I am copying Fudge into our mobans repository - it is only two files, and this means we can pin our version to a development version - and it is distributed from there to all of the coala repositories.

Three tweaks that would help.

  1. Remove trailing whitespace : https://github.com/Badgerati/Fudge/pull/72 While I am excluding the Fudge files from most of our linter rules, the one rule which I dont like to exclude files from is the 'no trailing whitespace' rule. Trailing whitespace causes git rebase to emit confusing messages, even when the rebase is not touching the files which have trailing whitespace.
  2. Allowing FudgeTools.psm1 to reside in the same directory as Fudge.ps1 , removing the need for a Modules subdirectory containing only a single file.
  3. The version Fudge reports is Fudge v$version$, likely because it couldnt find the correct version to report. The quick fix is to not report a version when there is no real version for the code being executed.
Badgerati commented 5 years ago
  1. I can do as apart of #61
  2. The $version$ is a placeholder that gets stamped in during release packaging. To be honest I've been thinking about removing the version messages, and have a -version parameter for Fudge (with the version hard-coded, and updated just prior to a release).