search

Badhamknibbs / SCPCB_DunGen_LC

Adds the SCP facility as a potential dungeon spawn in Lethal Company.
MIT License
0 stars 0 forks source link

Softlock after loading 2/3 moons #19

Open Entity378 opened 8 months ago

Entity378 commented 8 months ago

Apparently after lending and leaving a moon added by the LethalExpansionCore if you try to select and lend on a moon that can spawn the SCPFoundationDungeon the game will softlock.

This is the error the console gives when this happens: ConsoleERR

While this is what actually happens in the game: you can still move but you can't interact with anything and the seed always remains visible on the screen (loading is infinite) Bug

I tried to check if it was a LethalLevelLoader problem but it doesn't seem to be the case since using the Scoopys Variety Mod dungeon the problem doesn't happen

Entity378 commented 7 months ago

I discovered that apparently lethal expansion has nothing to do with this problem. Trying to put the list of moons RendLevel, DineLevel, TitanLevel and starting the game on each of them in order Rend->Dine->Titan on the third moon that I tried to load (Titan) the error occurred. I'm almost 100% sure that it's a SCPFoundationDungeon mod problem because if I try with other mods that generate custom dungeons (like the Scoopys Variety Mod) this problem doesn't occur.

Entity378 commented 7 months ago

@Badhamknibbs apparently the SpringtrapMask mod and SCPFoundationDungeon are incompatible with each other. This incompatibility causes the problem I described above. I don't know what causes the error (I think it's the item name change caused by the SpringtrapMask mod), but I'm 100% sure since I tested your mod individually with every single mod in my modpack for two days.

Badhamknibbs commented 7 months ago

@Badhamknibbs apparently the SpringtrapMask mod and SCPFoundationDungeon are incompatible with each other. This incompatibility causes the problem I described above. I don't know what causes the error (I think it's the item name change caused by the SpringtrapMask mod), but I'm 100% sure since I tested your mod individually with every single mod in my modpack for two days.

Ah, if it's replacing the existing item then it's failing to find the original asset for the mask and crashing when it assumes it can find it; I'll be adding a failsafe to it next patch to avoid that happening.

Entity378 commented 7 months ago

@Badhamknibbs apparently the SpringtrapMask mod and SCPFoundationDungeon are incompatible with each other. This incompatibility causes the problem I described above. I don't know what causes the error (I think it's the item name change caused by the SpringtrapMask mod), but I'm 100% sure since I tested your mod individually with every single mod in my modpack for two days.

Ah, if it's replacing the existing item then it's failing to find the original asset for the mask and crashing when it assumes it can find it; I'll be adding a failsafe to it next patch to avoid that happening.

I don't actually know if it completely replaces the object or just changes its name. If you're interested in the piece of code from the SpringtrapMask mod that breaks the mod it's this:

((Component)__instance).gameObject.GetComponentInChildren<ScanNodeProperties>().headerText = "Vintage Mascot Head";
((GrabbableObject)__instance).itemProperties.itemName = "Vintage Mascot Head";

For now I have published a version of the mod that does not change the name of the mask so you can use it without creating problems.

Badhamknibbs commented 7 months ago

I've made an update that'll gracefully fail if it can't find the item (it uses the item name so it won't have conversions but won't crash anymore). Once user/mod defined conversions are added it should be a fairly thing to implement