search

BadrIT / translation_center

Translation Center is a multi-lingual, GUI rich, community based, translation center for Rails apps
http://www.badrit.com/gems/translation_center/
MIT License
152 stars 71 forks source link

Rails 5 #80

Closed hzbadr closed 2 years ago

hzbadr commented 7 years ago
helsayed commented 7 years ago

:+1: I'm thinking should we update the readme with this rails 4 => gem 'translation_center' rails 5 => gem 'translation_center', branch: 'rails_5' till we make sure it works fine? what do you think?

scarroll32 commented 7 years ago

I think if the tests pass it should be merged. A lot of sites are on Rails 5 now.

amcamargoc commented 7 years ago

This looks like a fantastic gem! Is there any news on this PR? Thanks!

scarroll32 commented 7 years ago

I can't get this to install using gem 'translation_center', branch: 'rails_5' and Rails 5.0.2

Any tips on how to install this branch?

scarroll32 commented 7 years ago 
Fetching dependency metadata from https://rails-assets.org/..
Fetching dependency metadata from https://rubygems.org/.
Resolving dependencies....
Bundler could not find compatible versions for gem "activerecord":
  In snapshot (Gemfile.lock):
    activerecord (= 5.0.2)

  In Gemfile:
    translation_center was resolved to 2.0.2, which depends on
      audited-activerecord was resolved to 3.0.0, which depends on
        activerecord (~> 3.0)

    pghero was resolved to 1.6.4, which depends on
      activerecord

    pghero was resolved to 1.6.4, which depends on
      activerecord

    rails (~> 5.0.2) was resolved to 5.0.2, which depends on
      activerecord (= 5.0.2)

    rails-erd was resolved to 1.5.0, which depends on
      activerecord (>= 3.2)

    ranked-model was resolved to 0.4.0, which depends on
      activerecord (>= 3.1.12)

    activeadmin was resolved to 1.0.0.pre5, which depends on
      ransack (~> 1.3) was resolved to 1.8.2, which depends on
        activerecord (>= 3.0)

    activeadmin was resolved to 1.0.0.pre5, which depends on
      ransack (~> 1.3) was resolved to 1.8.2, which depends on
        activerecord (>= 3.0)

    rectify was resolved to 0.8.0, which depends on
      activerecord (>= 4.1.0)

    scenic was resolved to 1.3.0, which depends on
      activerecord (>= 4.0.0)

    seed_dump was resolved to 3.2.4, which depends on
      activerecord (>= 4)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
scarroll32 commented 7 years ago

This didn't work either

gem "rails-observers", github: 'rails/rails-observers' # Rails 5
gem 'translation_center', branch: 'rails_5'
scarroll32 commented 7 years ago

Have added a pull request to https://github.com/hzbadr/translation_center/pull/2 to fix many depreciation warnings and also support Rails 5.0.2

helsayed commented 7 years ago

@hzbadr is this ready to be merged ?