Charset.forName -> StandardCharsets & Linting fixes

Baekalfen / ICAP-avscan

Uploads a file to a ICAP server.

MIT License

47 stars 29 forks source link

Charset.forName -> StandardCharsets & Linting fixes #20

Closed gowthamgts closed 4 years ago

gowthamgts commented 4 years ago

The first commit will have the code changes and the second will have formatting fixes

Baekalfen commented 4 years ago

Your commit does have some merit, but I don't see all the changes as usable. I wouldn't say I disagree with your formatting changes, but I could see this be changed back and forth for every developer who likes the formatting differently.

But I want to say thank you anyway for your contribution and interest in the project :)

gowthamgts commented 4 years ago

Sure no problems. :)