Serial Support - Githubissues

Baekalfen / PyBoy

Game Boy emulator written in Python

Other

4.64k stars 476 forks source link

Serial Support #337

Closed Artucuno closed 2 months ago

Artucuno commented 3 months ago

Merged changes from master branch
Working implementation of Serial

Tested in:

Pokemon Yellow
- Trading
- Battle

Issues:

~~There is a small issue where the emulator will temporarily freeze when waiting for the other Gameboy to respond to data (Should be an easy fix for someone)~~ - Fixed in 7878718
Synchronization issues in some games, however Pokémon games work completely fine.
- Tetris
When compiled into Cython, PyBoy freezes after socket connection is established

Baekalfen commented 2 months ago

Sorry, I rebased your branch so that it was in line with the history of master and serial. For some reason, GitHub thought it should close the PR on the force-push...

Baekalfen commented 2 months ago

You can pull the branch from here and reopen the PR https://github.com/Baekalfen/PyBoy/tree/artucuno/serial

Artucuno commented 2 months ago

No worries, I'll reopen the PR soon 👍