Baekalfen / PyBoy

Game Boy emulator written in Python
Other
4.64k stars 476 forks source link

Small fix to README examples #347

Closed Artucuno closed 2 months ago

Artucuno commented 2 months ago

Updated no rendering example from

pyboy.tick(target) # render=False not set

to

for _ in range(target):
    pyboy.tick(render=False)
Baekalfen commented 2 months ago

Hmm. I mean it does render the last frame, but it will have minimal impact on performance (if target is large enough). Tried to strike a balance between simplicity and function for the example.

Maybe the best would be to reduce your example to pyboy.tick(target, False)?

Artucuno commented 2 months ago

Maybe the best would be to reduce your example to pyboy.tick(target, False)?

Good idea. I made the update 👍