search

BafDyce / botamusique

Bot to play local music on Mumble (using pymumble). youtube;soundcloud,radio soon.
MIT License
1 stars 0 forks source link

Bot crashes on receiving !playurl command without HTML formatting #51

Closed BafDyce closed 6 years ago

BafDyce commented 6 years ago

Describe the bug See Steps to reproduce.

Affected version be6b4d4088ccfa52b9b2642826b9a507f5bc73e0

Steps To Reproduce Steps to reproduce the behavior:

  1. Send the bot a private message with a !playurl <url> command without HTML formatting of the message.
  2. The bot crashes and disconnects from mumble

Expected behavior The bot should play the given sound file.

Screenshots/Log

Traceback (most recent call last):
  File "mumbleBot.py", line 350, in <module>
    botamusique = MumbleBot(args)
  File "mumbleBot.py", line 80, in __init__
    self.loop()
  File "mumbleBot.py", line 308, in loop
    self.launch_next()
  File "mumbleBot.py", line 238, in launch_next
    url = m.group(1)
AttributeError: 'NoneType' object has no attribute 'group'
bot exited with return code 1
BafDyce commented 6 years ago

I think this issue was fixed by this addition in an upstream change. We should wait until #52 was reviewed & merged, then check whether the issue still exists.

azlux commented 6 years ago

@BafDyce you're right, it's fixed

BafDyce commented 6 years ago

Great. Thanks for your input! Closing this now.