Baganator / Baganator

World of Warcraft Addon: Reliable single or categories view bag and bank with guild view, searching, sorting, browsing offline inventories, currency tracking and item location info tooltips.
https://www.curseforge.com/wow/addons/baganator
MIT License
32 stars 11 forks source link

Scap (Junk Seller) Addon Support #17

Closed srtzero closed 11 months ago

srtzero commented 11 months ago

Is your feature request related to a problem? Please describe. No problem, just a simple feature request to support the addon Scap. https://www.curseforge.com/wow/addons/scrap

Describe the solution you'd like Would like to see Scrap addon supported so coin icons can show on junk items to sell.

Describe alternatives you've considered You could always incorporate these features in Baganator natively.

plusmouse commented 11 months ago

There is no public interface for integrating Scrap into another bag addon - so this cannot be done.

plusmouse commented 11 months ago

Alternatively if all you want is coin icons on junk (as marked by their quality) that can be done separately.

srtzero commented 11 months ago

Im by no means an expert, but I thought somthing like this. https://www.curseforge.com/wow/addons/bagnon-scrap or https://www.curseforge.com/wow/addons/sorted-scrap

So how do they work with scrap? did they make an addon that creates support for scrap for those addons?

And yes ultimately would love to have coin icons on junk like scrap, and maybe even take it one step further and have an option to allow desaturation of junk items. Like a option with a slider on how desaturated you want the items to be.

plusmouse commented 11 months ago

The limitation here is that I'm not going to risk a copyright issue with Baganator should I try to implement Scrap support based on existing code.

plusmouse commented 11 months ago

Usually when an addon is intended to have parts embedded it includes documentation in the source code or a wiki to point developers to the parts they are meant to use.

srtzero commented 11 months ago

The limitation here is that I'm not going to risk a copyright issue with Baganator should I try to implement Scrap support based on existing code.

Ah understood. Like I said didnt know how those addons worked.

plusmouse commented 11 months ago

For "junk" items do you mean junk as determined by options (e.g ilvl filters) or as junk based on the item rarity being grey?

srtzero commented 11 months ago

Honestly if Bagator had the desaturation of juink items option and coins icon on junk items, I would be more than happy, and could even stop using scrap. I have like 4 other addons that can sell junk automatically. I was just using scrap for the smart junk filtering and showing coin icon on junk.

srtzero commented 11 months ago

For "junk" items do you mean junk as determined by options (e.g ilvl filters) or as junk based on the item rarity being grey?

I believe its by the items being gray. I guess there could be other filters added to what is defined as junk. But I think grey items are the safest.

plusmouse commented 11 months ago

In the latest alpha (and version in the sorting issue) find this option: image

srtzero commented 11 months ago

In the latest alpha (and version in the sorting issue) find this option

Awesome. Thank you.

srtzero commented 11 months ago

image Works well. Just what I was hoping for.

neyl66 commented 11 months ago

What I'm really missing is a keybind or some other way of just manually setting an item as a junk, instead of just manually set through the item quality type