Baganator / Baganator

World of Warcraft Addon: Reliable single or categories view bag and bank with guild view, searching, sorting, browsing offline inventories, currency tracking and item location info tooltips.
https://www.curseforge.com/wow/addons/baganator
MIT License
32 stars 11 forks source link

Re-add the ability to ignore slots when sorting #270

Closed tom-etchells closed 1 month ago

tom-etchells commented 1 month ago

What version(s) of WoW are you using?

Retail

What problem are you experiencing that led to you asking for this feature?

I see from the change-log that this feature wasn't frequently used but I don't understand why it needed to be removed? This change has made how I use this addon and organize my bags a fair bit worse. I guess I can use the Blizzard sorting style and ignore cleanup options but it is much less elegant than the previous solution.

I could understand if this was a really buggy feature that was taking lots of dev-time or was otherwise troublesome, if that's the case then fair enough. But if that's not the case (it doesn't seem to have been touched in any recent updates...) then why remove the feature?

What solution would you like?

Re-add the feature to ignore slots when sorting.

Any alternatives you can think of?

No response

Anything else?

Whilst this update is annoying for me, I still think the addon is great so cheers for all the work on it.

Odaxis commented 1 month ago

This was one of the key features for me using this addon, downgrading to a previous version and blocking future updates till this is revised and restored or i find a better replacement addon.

plusmouse commented 1 month ago

It was removed to simplify the sorting code, and because less than 1% (almost 0%) of users were using it. The feature was added Thu Nov 30 2023, so if it was relevant to a lot of users I'd have expected more usage by now.

tflo commented 1 month ago

I second this 100%.

The ability to ignore slots was one of the best Baganator features (if we talk about the Single Bag view, it is less relevant if you use Category view exclusively).

All my toons have certain items that shouldn’t be sorted. These are things like the 3 guild teleport cloaks, other teleport items, Army Knife, Accursed Keepsake, Elune Stones, Pet Bandages, and similar stuff. I call them the toons “private” items, you get the idea.

With Blizz Bags, it was always the last bag that was reserved for this stuff, and I excluded this bag from sorting of course, because it doesn’t make sense to see my teleport cloaks sorted along with regular gear.

With Baganator’s Ignore Sorting it was so much better, because the number of protected slots was flexible.

Removing this would really be a huge regression.

If you really insist in doing so, then please make the Baganator sorting methods respect the Blizz Ignore Cleanup bag flag, so we could at least protect a bag. Otherwise the Baganator sort methods become de facto unusable und we are basically forced to only ever use the Blizzard sort method (which respects the bag flags).

Thanks for considering!

plusmouse commented 1 month ago

Restored in v471, out shortly.

tflo commented 1 month ago

Restored

Thank you so much! 🥰