Baganator / Syndicator

World of Warcraft addon to keep track of where your items are in all your characters bags, banks, mails, void storage, auctions and guilds. Used by Baganator.
https://www.curseforge.com/wow/addons/syndicator
MIT License
5 stars 3 forks source link

Transfer tracking when the transfer has a tax #42

Closed ESpmdark closed 2 months ago

ESpmdark commented 2 months ago

What version(s) of WoW are you using?

Retail

What version of Syndicator?

107

What isn't working? What was supposed to happen?

This will be somewhat less than helpful bug-report. As I did not submit the report while it was fresh in my mind:

A couple of days ago (I think I was on version 107 then), I did a currency transfer that had a % loss. Example values (since I dont remember the spesifics): 10k from source 2k lost 8k to new character

Syndicator tracked only 8k removed from the source character, where it should have retracted 10k from the source currency-count.

I dont have more of the currency to test if this is fixed in newer versions, but I'd rather submit a heads up -report for you incase you werent aware of this.

Are you experiencing any lua errors

No response

Anything else?

No response

plusmouse commented 2 months ago

What currency has a transfer tax?

zeenk commented 2 months ago

https://www.wowhead.com/news/transfering-currencies-within-your-warband-available-currencies-transfer-rates-339048

dno if this list is updated anymore though, anima is not transferable anymore but it's on the list

ESpmdark commented 2 months ago

image Honor was added to the tax list aswell. So that article is outdated. I cant find a solid list for this.

C_CurrencyInfo.GetCurrencyInfo()

will however allow you to check for: image

https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCurrencyInfo doesnt list that tablevalue, but its a part of the function for the API currently and you get it for all. Standard is a value of 100

plusmouse commented 2 months ago

Thanks for the detailed report. I've added taking the transfer tax into account into the latest alpha now :)