search

Baganator / Syndicator

World of Warcraft addon to keep track of where your items are in all your characters bags, banks, mails, void storage, auctions and guilds. Used by Baganator.
https://www.curseforge.com/wow/addons/syndicator
MIT License
5 stars 4 forks source link

Syndicator error created by [Pet cage] item in Guild Bank #50

Open JunkHead1979 opened 4 days ago

JunkHead1979 commented 4 days ago

What version(s) of WoW are you using?

Retail

What version of Syndicator?

Syndicator-124

What isn't working? What was supposed to happen?

Lua error created when opening guild bank which had an item, [Pet Cage] on tab 1. Item has red text, "This was never available to players." Removing the item from the guild bank stopped error from occurring. Below I will paste error.

Are you experiencing any lua errors

Message: Interface/AddOns/Syndicator/Tracking/Utilities.lua:51: attempt to concatenate field '?' (a nil value) Time: Mon Sep 23 17:14:09 2024 Count: 6 Stack: Interface/AddOns/Syndicator/Tracking/Utilities.lua:51: attempt to concatenate field '?' (a nil value) [string "@Interface/AddOns/Syndicator/Tracking/Utilities.lua"]:51: in function RecoverBattlePetLink' [string "@Interface/AddOns/Syndicator/Tracking/GuildCache.lua"]:295: in functionDoSlot' [string "@Interface/AddOns/Syndicator/Tracking/GuildCache.lua"]:314: in function ExamineBankTab' [string "@Interface/AddOns/Syndicator/Tracking/GuildCache.lua"]:243: in functionExamineAllBankTabs' [string "@Interface/AddOns/Syndicator/Tracking/GuildCache.lua"]:164: in function <Interface/AddOns/Syndicator/Tracking/GuildCache.lua:162>

Locals: tooltipInfo =

{ dataInstanceID = 8078 type = 0 isAzeriteEmpoweredItem = false isAzeriteItem = false id = 82800 hyperlink = "[Pet Cage]" isCorruptedItem = false lines =
{ } } itemString = "battlepet" (for state) =
{ 1 = "battlePetSpeciesID" 2 = "battlePetLevel" 3 = "battlePetBreedQuality" 4 = "battlePetMaxHealth" 5 = "battlePetPower" 6 = "battlePetSpeed" } (for control) = 1 _ = 1 key = "battlePetSpeciesID" (temporary) = "battlepet" (temporary) = ":" (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to concatenate field '?' (a nil value)" battlePetTooltip =
{ 1 = "battlePetSpeciesID" 2 = "battlePetLevel" 3 = "battlePetBreedQuality" 4 = "battlePetMaxHealth" 5 = "battlePetPower" 6 = "battlePetSpeed" }

Anything else?

No response

zeenk commented 4 days ago

Did you recently transfer faction or realm or is that "pet" part of the items you got back from the broken guild banks? https://www.wowhead.com/item=82800/pet-cage#comments

Reading some wowhead comments about it and people seem to get this if the pet gets broken and is no longer useable or something 🤔

JunkHead1979 commented 4 days ago

Nope! I just recently came back to the game after having not really played since Legion. This item has been in the guild bank for years. Now, I do remember many years ago, I did have to do a guild bank restore from a hack attempt. It occurred in October 2013 according to my email. Could that be the issue?

zeenk commented 4 days ago

That could be the cause as the restored item wasn't able to be fully restored, so that pet you had might be gone forever (But keep it for now if plusmouse, the Baganator dev) needs to do some testing to avoid this issue in the future.

JunkHead1979 commented 4 days ago

Yeah np. I moved it to my normal bank and there is no error. So perhaps it was isolated to gbank only. But yeah i still have it. I will also sow a screenshot just to add more info. WoWScrnShot_092324_173235

JunkHead1979 commented 4 days ago

Also adding more info. And this is complicated to type, so hopefully it makes sense. With Baganator/syndicator both enabled, in addition to the lua error I pasted above, the guild bank also looked different. Tab 1 was completely empty except for one item in the top left most slot. changing to another tab, say tab 2, then BACK to tab 1, now showed tab 1 as having items, but it was the items from the previous tab you viewed. If that makes any sense.

plusmouse commented 4 days ago

That would make sense, the scan failed because of the broken pet cage. so one tab wouldn't refresh properly.

plusmouse commented 4 days ago

I'll add some shielding code tomorrow to ensure that if this happens again it'll just be missing the pet icon, and not break the guild bank entirely.

JunkHead1979 commented 4 days ago

This is probably not something that will occur often but I'm glad I could help nonetheless. :)

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.