search

Bagenholm / sfrpg-globalattack

MIT License
0 stars 1 forks source link

Global attack adding wrong values #5

Closed Grizlug closed 9 months ago

Grizlug commented 10 months ago

when rolling an attack, global attack adds the wrong value for @abilities.str.mod or @abilities.dex.mod and @attributes.baseAttackBonus.value

the values added are very high and seem to be higher the more options added to the module, sometimes as high as 30 for BAB, as an example.

running V11 Foundry starfinder version 0.25.2

Bagenholm commented 9 months ago

Thanks for the report. Fixed in 1.0.5

LumberKing commented 8 months ago

Using the latest version yet I am still having trouble with this.

Bagenholm commented 8 months ago

Using the latest version yet I am still having trouble with this.

I can no longer reproduce it. Which version does it say you're using?

LumberKing commented 8 months ago

Using the latest version yet I am still having trouble with this.

I can no longer reproduce it. Which version does it say you're using?

I am using Foundry V11 Build 315, Starfinder 0.25.2, and the module version is 1.0.5. I should also add the caveat that these are ongoing games that had previously used the older edition (as back as V9).

Bagenholm commented 8 months ago

Try to remove all the modifiers and add them again :)

Den tors 14 dec. 2023 16:05Hansol @.***> skrev:

Using the latest version yet I am still having trouble with this.

I can no longer reproduce it. Which version does it say you're using?

I am using Foundry V11 Build 315, Starfinder 0.25.2, and the module version is 1.0.5. I should also add the caveat that these are ongoing games that had previously used the older edition (as back as V9).

— Reply to this email directly, view it on GitHub https://github.com/Bagenholm/sfrpg-globalattack/issues/5#issuecomment-1856017838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHHPFOF37LZZXHT52IXV43YJMISRAVCNFSM6AAAAAA6LLWBHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGAYTOOBTHA . You are receiving this because you modified the open/close state.Message ID: @.***>

LumberKing commented 8 months ago

Try to remove all the modifiers and add them again :) Den tors 14 dec. 2023 16:05Hansol @.> skrev: … Using the latest version yet I am still having trouble with this. I can no longer reproduce it. Which version does it say you're using? I am using Foundry V11 Build 315, Starfinder 0.25.2, and the module version is 1.0.5. I should also add the caveat that these are ongoing games that had previously used the older edition (as back as V9). — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHHPFOF37LZZXHT52IXV43YJMISRAVCNFSM6AAAAAA6LLWBHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGAYTOOBTHA . You are receiving this because you modified the open/close state.Message ID: @.>

That did the trick. Must have been some sort of leftover code from the legacy version. Churs!