Bagoro / connectbot

Automatically exported from code.google.com/p/connectbot
Apache License 2.0
0 stars 0 forks source link

localised post r232 fail when connecting to a new host #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download a localised r233 or 234 build
2. set your system language to something other than english (it helps if
you speak the language :-) )
3. try to connect to a *new* ssh keys (you can also delete an old one and
try to reconnect)

What is the expected output? What do you see instead?

I expect a localised version of "key from host ... is ..." but that line
never appears, instead the session is closed with "Key exchange was not
finished from the server" (or something).

I suspect the bug happens in org.connectbot.transports.SSH.java, just after
case KnownHosts.HOSTKEY_IS_NEW, maybe because an exception is thrown during
one of the getString methods, probably

bridge.outputLine(String.format(manager.res.getString(R.string.host_fingerprint)
,
algorithmName, fingerprint));

or maybe the next call.

What version of the product are you using (you can see this by using Menu
-> About in the Host List)?

What type of system are you trying to connect to?

If you are able to connect, what is the output of "echo $TERM", "uname -a",
and any other relevant information on the host?

Please provide any additional information below.

Original issue reported on code.google.com by tau...@gmail.com on 14 May 2009 at 2:57

GoogleCodeExporter commented 9 years ago
Problem seems to occur due to botched format specifiers in localised strings. 
The
place where it crashes or fails depends on the broken string. In my case it was 
in 
<string name="host_fingerprint">Fingerabdruck von Host %1$s
Schlüssel ist %2$</string>

'%2$' should be '%$2s'.

Original comment by tau...@gmail.com on 14 May 2009 at 3:30

GoogleCodeExporter commented 9 years ago
It looks like some buggy strings in translations. I added some checks to the 
python
script that converts back and forth. Fixed in r325

Original comment by kenny@the-b.org on 14 May 2009 at 5:52