search

BaguaSys / bagua

Bagua Speeds up PyTorch
https://tutorials-8ro.pages.dev/
MIT License
872 stars 83 forks source link

autotune service: fix typing #58

Closed NOBLES5E closed 3 years ago

NOBLES5E commented 3 years ago

We need to fix some type mismatch in the current implementation:

autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 173, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 180, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 187, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
create-issue-branch[bot] commented 3 years ago

Branch issue-58-autotune_service_fix_typing created!

shjwudp commented 3 years ago

#67 style: fix pytype warnings