search

BahamutDragon / pcgen

PCGen Data Sets
308 stars 337 forks source link

Cannot create character using "Final Fantasy" (FFD20) dataset #1173

Closed pokemonpasta closed 1 year ago

pokemonpasta commented 1 year ago

Trying to create a character to test some things (I'm actually looking to update this dataset as the current implementation is quite old now, if you'd welcome a PR) but when I try to create a character I get

Unable to create a new character. The error was: Cannot invoke "pcgen.base.solver.Modifier.process(pcgen.base.formula.EvaluationManager)" because "defaultModifier" is null.

This only occurs on this dataset, other sets are working fine (which leads me to believe it's a data issue), and I've tried it with 6.08 data on 6.08.00RC10, and master data on 6.08.00RC8 and 6.08.00RC10 with the same results. This set is the only one loaded when I try this (trying to load core pf1e datasets at the same time just leads to ambiguous reference problems, so I assume this set is supposed to be loaded by itself)

Steps to Replicate

  1. Run 6.08.00RC8 or 6.08.00RC10 versions of PCGen with master or 6.08 branch of this repo loaded
  2. Load "Final Fantasy" dataset by itself
  3. Create a new character

Expected outcome New character windows opens as expected, with relevant data ready to use

Actual outcome Error listed above, and no character window is opened

Log: https://pastebin.com/a9xiJRfD

BahamutDragon commented 1 year ago

That is only possible if you are using Master gamemodes while running 6.08 data. You need to change your gamemodes to 6.08 version.

pokemonpasta commented 1 year ago

As I mentioned above, I'm getting this issue when using 6.08 branch. I tried again on another fresh install of 6.08.00RC10 with 6.08 branch data and am still getting this error (gamemode files are the PCGen pathfinder files installed fresh with 6.08.00RC10, as the ffd20 source uses pathfinder1e as a gamemode)

BahamutDragon commented 1 year ago

Does a normal Pathfinder game give the error?

pokemonpasta commented 1 year ago

No, I can create regular pathfinder characters just fine (6.08.00RC10 with release data and gamemode)

BahamutDragon commented 1 year ago

Update and give that a try.

pokemonpasta commented 1 year ago

Still not working, but there's a different error this time which I suppose is progress. Using 6.08 branch data

Unable to create a new character. The error was: Cannot invoke "pcgen.cdom.base.CDOMObject.get(pcgen.cdom.enumeration.ObjectKey)" because "po" is null.

Log

pokemonpasta commented 1 year ago

I asked in the PCGen discord and apparently this error is from DEFAULTVARIABLEVALUE:DEITY not having a value, so DEFAULTVARIABLEVALUE:DEITY|None might fix it

EDIT: Nvm, I see you've done that on the master branch

Vest commented 1 year ago

One more thing to add. There is a folder "_universal" with a small file races.lst. It has a race that is always selected, when you create a new character. I have checked random PCC files (especially Final Fantasy), and found out that you forgot to add this line:

RACE:*/_universal/races.lst

It must be included, otherwise PCGEN cannot select a None race :)

BahamutDragon commented 1 year ago

Issue found and addressed. Thanks mates for the deeper dive.