BahamutDragon / pcgen

PCGen Data Sets
308 stars 337 forks source link

Feat description is not shown [pcgen 6.07.01] #670

Closed shadowfury closed 7 years ago

shadowfury commented 7 years ago

After i picked up latest update of sources feat info failed to load every time and is blank every time. In log this error is shown every time i select feat. It seems like it misses needed info. Perhaps i need to put additional output?

image

BahamutDragon commented 7 years ago

I would need the full text of the log. Once PCGen generates a Null Pointer Exception "NPE" all bets are off. What feat did you try to add?

shadowfury commented 7 years ago

This was entire log. It happen every time i select any feat (click on it in Feat& Abilities > Feat > Name tab). Nothing is shown in Feat Info window and such error is shown in log.

For a new character that switched to feat tab and clicked on any feat i see following in log:

22:03:23.457 INFO main LanguageBundle:136 Initialising language bundle with locale en_US. 22:03:43.763 INFO Thread-6 SourceFileLoader:560 Loading game 35e and sources [Complete Adventurer, Complete Arcane, Complete Champion, Complete Divine, Complete Mage, Complete Scoundrel, Complete Warrior, Dungeon Master's Guide II, Dungeons & Dragons - Core Books, Expanded Psionics Handbook, Fiendish Codex II, Magic Item Compendium, Miniatures Handbook, Monster Manual II, Monster Manual III, Player's Guide to Faerun, Player's Handbook II, Spell Compendium, Unearthed Arcana (Complete), Races of Destiny]. 22:03:58.545 INFO AWT-EventQueue-0 CharacterManager:107 Created new character Unnamed 1. 22:04:07.429 SEVERE AWT-EventQueue-0 Main:581 Uncaught error - ignoring java.lang.NullPointerException at pcgen.gui2.facade.Gui2InfoFactory.appendFacts(Gui2InfoFactory.java:2420) at pcgen.gui2.facade.Gui2InfoFactory.getHTMLInfo(Gui2InfoFactory.java:557) at pcgen.gui2.tabs.AbilityChooserTab$InfoHandler.valueChanged(AbilityChooserTab.java:445) at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source) at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source) at javax.swing.DefaultListSelectionModel.setValueIsAdjusting(Unknown Source) at javax.swing.plaf.basic.BasicTableUI$Handler.setValueIsAdjusting(Unknown Source) at javax.swing.plaf.basic.BasicTableUI$Handler.mouseReleased(Unknown Source) at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source) at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source) at java.awt.Component.processMouseEvent(Unknown Source) at javax.swing.JComponent.processMouseEvent(Unknown Source) at java.awt.Component.processEvent(Unknown Source) at java.awt.Container.processEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source) at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEventImpl(Unknown Source) at java.awt.EventQueue.access$500(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.awt.EventQueue$3.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.awt.EventQueue$4.run(Unknown Source) at java.security.AccessController.doPrivileged(Native Method) at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source)

shadowfury commented 7 years ago

I think i know what happened - i noticed this bug a few days ago and it started to reproduce with all source book selection. Another thing that also happen a few days ago - i updated java to latest version (1.8.0_131-b11 (Oracle Corporation)). I think that's why i am punished, not related to sources

BahamutDragon commented 7 years ago

I cannot fix a Java release issue. I think this would be best directed to the pcgen team. They have the resources to investigate and correct these problems.

shadowfury commented 7 years ago

Yeah, i should have checked java earlier, not first time i've encountered weird behavior due to java version. I wish there was a java version requirement with each pcgen release that is guaranteed to work without issue

shadowfury commented 7 years ago

Strange thing is that when i only load this book i get no error on feat clicks: image but when i load a single core book this one

image

i get zero info on a feats and null pointer exceptions. As if these core rules book contains some error or i miss some game mode info or something

shadowfury commented 7 years ago

Another update - i loaded sources that were on Commits on Mar 20, 2017 - at this commit - 0f72852786538e4281abde62036596d107378936 And bug error is not present! Trying to narrow it down to find commit that broke things

shadowfury commented 7 years ago

I found commit that broke feats info tab and a few other tabs (spell description also i think). It's this Warforged change - https://github.com/BahamutDragon/pcgen/commit/43635482763ea4479830d9b82deba158874716be

previous commit does not have this behavior

https://github.com/BahamutDragon/pcgen/commit/53fb4d020449757fa098a2c84362a7b5d657ed64

BahamutDragon commented 7 years ago

Mate, I loaded the same source, and my feats show just fine.

BahamutDragon commented 7 years ago

image I typically test my commits before I upload to verify nothing breaks

BahamutDragon commented 7 years ago

The 3.5e sources I support really should be using the Bahamut35e GameMode, as the referenced commit is only supported in my GameMode.

shadowfury commented 7 years ago

I again reinstalled pcgen (with java version included with install), downloaded clean latest sources, pasted them to /vendordata, copied gameMode folder, loaded single book in Bahamut 3.5e mode image and still have this issue even in Bahamut mode image I have no idea what am i missing

and even if i figure out how to make it work, it looks like i'll need to redo all characters i made for 3.5 from scratch, as they had different game mode. Is there a way to make that single change to be loaded only when in Bahamut mode?

BahamutDragon commented 7 years ago

Simple edit made to the character file can make an existing character work. I would not worry about it though. The edit is for making the Warforged characters work correctly. No other major deviations between my gamemode and the pcgen supplied version. Other than it will help you avoid loading books not fully supported.

I am not running the latest java version like you, which sounds like a likely suspect. I will upgrade my java and see if that impacts anything on my end.

shadowfury commented 7 years ago

I assume it means changing line GAMEMODE:35e in character file. Thanks for pointing out!

About java - i uninstalled my system java and instead downloaded this release of pcgen - https://sourceforge.net/projects/pcgen/files/PCGen%20Unstable/6.07.01/

it comes already with java within pcgen folder - pcgen-6.07.01-full.zip.

I checked and it uses java version "1.8.0_66" which is presumable desired version for pcgen as it is packed with it. Though it works correctly with sources previous to warforged commits. If java was issue it would have probably failed in both versions of sources

BahamutDragon commented 7 years ago

I do not know the full ins and outs of what the pcgen team does. You can reach out to them direct. They have a live chat that frequently has their team in it. Reach out and ask them, they may have further. This is the link they always promote: https://www.hipchat.com/gzYdCc3Vn

shadowfury commented 7 years ago

As a temporary solution i had to revert those two commits in my fork, hopefully this is only my issue and when 6.08.01 is released i'll just grab correct version. Meanwhile, interesting merges for me ahead :) Sorry for taking your time mate and thanks for help!