search

BahamutDragon / pcgen

PCGen Data Sets
306 stars 338 forks source link

Base Attack Bonus not totaling correctly for Drd 5/MMF 3/Warshaper1 #98

Closed bmhanson closed 10 years ago

bmhanson commented 10 years ago

To recreate this issue I am in game mode 3.5 and have the core source, Complete Warrior and Complete Adventurer defined.

I am having an issue where the BAB values do not seem to be stacking correctly. You can see the issue when you add 5 levels of Druid, 3 levels of Master of Many Forms and then 1 level of Warshaper.

Here are the class defined BAB.

Druid level 5 is +3 MMF level 3 is +2 Warshaper level 1 is +0

Totaling them up the BAB should be +5 for a Drd 5 / MMF 3 / Wsh 1. The program is showing a BAB of +6/+1.

I did try replacing the BONUS for BAB on Druid, Warshaper and MMF with BONUS:COMBAT|BAB|CL*3/4|TYPE=Base.REPLACE which I took from the core PCGEN lst files and the bonuses correctly calculate but it warns that BAB is deprecated and to use BASEAB. I try the same with BASEAB instead of BAB and then it starts to be flaky and work sometimes. Other times it may change the BAB to 0.

Unfortunately I have not been able to find anything documenting what the difference is, if anything between BAB and BASEAB. Nor can I ascertain if this is a LST issue or a PCGEN bug.

BahamutDragon commented 10 years ago

Had some help from the experts to solve this sly bug. BASEAB was not manifesting correctly due to incorrect System tags. Warshaper had an incorrect BAB progression. While I was in there, added some other standard PCGen conventions for compatibility.