search

BahamutoD / BDArmory

Gun turrets and other weapon systems for KSP
38 stars 113 forks source link

Fixed missile legacy targeting attempting to use the newer systems. #5

Closed Yskinator closed 9 years ago

Yskinator commented 9 years ago

Fixed legacy targeted missiles trying to call Update[TargetingType]Target() functions due to what should have been an else-if being an if.

BahamutoD commented 9 years ago

I'm denying this because missiles under legacy targeting still need to be able to acquire flares or be affected by chaff/ecm, which is updated in the other methods, although since UpdateLegacyTarget keeps overwriting the heat/radar target, something else needs to be done to let it know if the lock on the original target vessel has been broken.

Yskinator commented 9 years ago

Would it be better to have a legacy targeting check at the beginning of those Update[TargetingType]Target() methods, deal with the countermeasures there, and leave the function before it tries to use the new targeting system and runs into null refs, or would you prefer to add the countermeasure logic inside UpdateLegacyTarget()? Whichever you prefer, I'll see if I can add it later today.

Yskinator commented 9 years ago

Looking at the current CM code, it can't really be used as is with legacy targeting, so I dug up some of your old flare code and made it work with the current version. I'll see if I can make something similar for the other counter measures, and then call that from UpdateLegacyTarget().

Does that sound about right, or do you want me to do something else or leave it alone for now?

Yskinator commented 9 years ago

UpdateLegacyTarget() now uses the old flare logic for flares. Still need to do the other countermeasures though.

BahamutoD commented 9 years ago

Just leave it for now. What I want for legacy targeting is to just give the missile the data it needs on launch or in flight for the new targeting to work. That way we don't need to worry about two different systems all the time.

On Sat, Aug 15, 2015 at 6:45 PM, Yskinator notifications@github.com wrote:

UpdateLegacyTarget() now uses the old flare logic for flares. Still need to do the other countermeasures though.

— Reply to this email directly or view it on GitHub https://github.com/BahamutoD/BDArmory/pull/5#issuecomment-131461207.

Yskinator commented 9 years ago

Alright. I'll get back to blowing things up in space then :)

Yskinator commented 9 years ago

BahamutoD's superior fixes will be used instead.