Changed the id constraint to fhirId and also changed the deprecated I…

ayku686 commented 1 year ago

…d constraint of Fhir package to FhirId. In jitsi package changed the type of activity to activity?

upgraded jisti_meet package to newer version jisti_meet_fix

All the packages needed to be upgraded since installation was not finishing. Many developers were facing issue during installation at their local machine

CLAassistant commented 1 year ago

All committers have signed the CLA.

angshu commented 1 year ago

I think only jitsi_meet_fix is required at this point. Others we can migrate going forward

ayku686 commented 1 year ago

Dear sir Fhir no longer supports the Id class and in the newest version on it Id class is replaced by FhirId

On Sun, Jun 4, 2023, 3:20 PM angshuman sarkar @.***> wrote:

@.**** commented on this pull request.

In lib/domain/models/omrs_patient.dart https://github.com/Bahmni/connect2Bahmni/pull/4#discussion_r1216479654:

@@ -17,7 +18,7 @@ class OmrsPatient {

fhir.Patient toFhir() { return fhir.Patient(

id: fhir.Id(uuid),

fhirId: FhirId(uuid).toString(),

also you don't need to case uuid to fhirId and back to string again .. just fhirId: uuid should suffice

— Reply to this email directly, view it on GitHub https://github.com/Bahmni/connect2Bahmni/pull/4#pullrequestreview-1461079044, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2BZLMS27BPFZE3XUHLHK2DXJRK5JANCNFSM6AAAAAAYZICQYI . You are receiving this because you authored the thread.Message ID: @.***>

Bahmni / connect2Bahmni

Changed the id constraint to fhirId and also changed the deprecated I… #4

@.**** commented on this pull request.