README - Githubissues

Bahn-X / swift-composable-navigator

An open source library for building deep-linkable SwiftUI applications with composition, testing and ergonomics in mind

MIT License

581 stars 25 forks source link

README #57

Closed oliverlist closed 3 years ago

oliverlist commented 3 years ago

Fix typo in main README
Add Example README with installation steps

Problem

The Example app was missing installation steps

Solution

Add a minimal Example/README.md

github-actions[bot] commented 3 years ago

Current coverage for ComposableDeeplinking.framework is `100.00%`

Files changed	-	-
Deeplink.swift	`100.00%`	:white_check_mark:

Current coverage for ComposableNavigator.framework is `96.82%`

✅ No files affecting coverage found

Current coverage for ComposableNavigatorTCA.framework is `98.46%`

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

ohitsdaniel commented 3 years ago

The reason why we currently generate the XcodeProj for the Swift Package is a weird bug in the coverage report that lists the library targets twice when the package is added as a local SPM package. I was looking into this and did not find a solution for it. It's also reproducible in a simpler SPM package setup and running tests via xcodebuild --enable-coverage.

This PR is okay for now, but I think we should gather coverage data through the package tests only and 'ignore' the UI tests in it. We could translate the coverage report generated by Xcode to lcov and pipe its output into codecov.