search

Bahn-X / swift-composable-navigator

An open source library for building deep-linkable SwiftUI applications with composition, testing and ergonomics in mind
MIT License
580 stars 25 forks source link

Readme tweaks #67

Closed ZevEisenberg closed 3 years ago

ZevEisenberg commented 3 years ago

Minor ReadMe cleanup.

ohitsdaniel commented 3 years ago

Rest looks fine, thanks for the contribution! 🍨 🏅

ohitsdaniel commented 3 years ago

I just merged #68 and I think that should resolve the failing CI run. I rebased the PR for you to see if it succeeds now. :)

ohitsdaniel commented 3 years ago

Hey @ZevEisenberg ,

sorry for butchering your PR, Danger keeps failing when it's running from your fork and I can't really debug it unless the PR comes from an external fork. 😬 Will try my best to resolve this issue ASAP.

ohitsdaniel commented 3 years ago

Decided to temporarily disable Danger as it's not working with the standard GITHUB_TOKEN from forks. Will setup a bot account for Danger and use secrets in the future, but for now, I'll just disable it to unblock this PR. :)

ZevEisenberg commented 3 years ago

@ohitsdaniel should be all set