search

BaijnathG / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Code review request: German Translation, slight modification to master strings.xml #257

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Mercurial clone with changes to be reviewed:

http://code.google.com/r/mariansteinbach-mytracks

Revisions to be pulled from that clone (or "all"):

English master strings.xml:
http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=2b7faf1b9b6e76
71cfa4b3de04a0dcee256ded03

German translation:
http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=3af23c797b6597
baec6f53a8abd4abaffd9ceeb6

Purpose of code changes on the clone:

- Addition of german translation
- Modification of german translations, e.g. cleaned up uses of "Du"
- Slight comment modification in english master file

Original issue reported on code.google.com by marian.s...@gmail.com on 2 Jan 2011 at 11:42

GoogleCodeExporter commented 9 years ago 
Can you review this change:
http://code.google.com/p/mytracks/issues/detail?id=164

That has been outstanding for some time.  I would rather get that in then if 
you have more changes we can apply that afterwards.

Original comment by sandordo...@google.com on 3 Jan 2011 at 3:58

GoogleCodeExporter commented 9 years ago 
OK, will do that. You can pull in the english file anyway. 
http://code.google.com/r/mariansteinbach-mytracks/source/detail?r=2b7faf1b9b6e76
71cfa4b3de04a0dcee256ded03

Original comment by marian.s...@gmail.com on 3 Jan 2011 at 5:18

GoogleCodeExporter commented 9 years ago 
I pulled in the other German changes.  Please merge with head and apply your 
changes on top of the new version.  I cannot comment on your files so I don't 
think you have code reviewing enabled. {Admister->Source->Enable code reviews & 
allow non-members to review.]

I general I actually don't support your EN changes.
The settings strings are separate from the general back up strings.  I like 
that comment where it is.
Please don't rename the sensor section.  If you want to add a sub-comment 
explaining that watts is a unit of power that is fine.

Original comment by sandordo...@google.com on 4 Jan 2011 at 12:53

GoogleCodeExporter commented 9 years ago

Original comment by sandordo...@google.com on 14 Jan 2011 at 12:43