search

BaijnathG / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Request for implementation of Issue 45 solution to be merged in #320

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Mercurial clone with changes to be reviewed:
http://code.google.com/r/dhpiggott-mytracks/

Revisions to be pulled from that clone (or "all"):
db883ab8af

Purpose of code changes on the clone:
Implementing Issue 45

When reviewing my code changes, please focus on:
n/a

Original issue reported on code.google.com by dhpigg...@gmail.com on 13 Feb 2011 at 10:29

GoogleCodeExporter commented 9 years ago

Original comment by simmonmt@google.com on 14 Feb 2011 at 12:35

GoogleCodeExporter commented 9 years ago 
I've implemented the changes requested and the revision to be pulled is now 
b48503a6e1. Dialogs are used instead of Toast for important messages but there 
is no dialog to select which files to import; I don't have time to do something 
like that right now, but it's a possibility in the future.

41cc0139b7 contains the actual changes; due to an Eclipse misconfiguration the 
indentation was all wrong but didn't show as wrong until I viewed it on Google 
Code (this is also the reason some indentation in db883ab8af was wrong). 
b48503a6e1 has the correct indentation. Sorry about this. This is my first time 
using hg, but hopefully you can merge the commits into one for tidiness.

Original comment by dhpigg...@gmail.com on 14 Feb 2011 at 11:29

GoogleCodeExporter commented 9 years ago 
Please enable code reviews in your clone.  See the instructions here:

http://code.google.com/p/mytracks/wiki/DevelopmentProcess#Making_a_clone_of_the_
repository

Original comment by simmonmt@google.com on 15 Feb 2011 at 12:36

GoogleCodeExporter commented 9 years ago 
I enabled code reviews when I set the clone up so I'm not why you're requesting 
I enable them. I'm going to make the changes requested in the reviews of 
41cc0139b7 and b48503a6e1 when I get chance, but I'm busy right now so it will 
probably be several hours from now.

Original comment by dhpigg...@gmail.com on 15 Feb 2011 at 12:43

GoogleCodeExporter commented 9 years ago 
I've implemented the changes requested and improved the external storage access 
(it now checks that external storage is readable before attempting to find GPX 
files and uses FileUtils.buildExternalDirectoryPath rather than hard-coding 
"sdcard").

The new revision is 49aa1528bf.

Original comment by dhpigg...@gmail.com on 16 Feb 2011 at 1:37

GoogleCodeExporter commented 9 years ago 
I've removed the this. from this.fileUtils = ... I realised my mistake just 
after committing 49aa1528bf but wasn't sure it warranted an extra commit; as it 
was picked up on I've made the change and committed it.

The new revision is da679f85ac.

Original comment by dhpigg...@gmail.com on 16 Feb 2011 at 8:23

GoogleCodeExporter commented 9 years ago 
Pushed to head.  Thanks again.

Original comment by sandordo...@google.com on 16 Feb 2011 at 3:43