search

BaileyJM02 / markdown-to-pdf

A GitHub Action to make PDF and HTML files from Markdown
MIT License
131 stars 32 forks source link

Allow user to feed customised values for parameters #8

Open bernardkkt opened 4 years ago

bernardkkt commented 4 years ago

Greetings. I have tried a couple of tools to convert .md to .pdf using GitHub, so far yours works the best. Thanks for the great job!

Regarding the subject line, I am actually referring to this particular line: https://github.com/BaileyJM02/markdown-to-pdf/blob/053ffdac92cf549d064dc8f6d5128e0d9e5f1dbd/markdown-to-pdf.js#L141

If I am not wrong, those items are the options for page.pdf(), and I feel it would be good if you could provide us a way to feed in our values. I didn't realise the default values there could actually cause an issue until I saw my table headings are missing out their background colours. It could be fixed if I am able to set printBackground to true.

BaileyJM02 commented 4 years ago

Hey, this certainly is a good feature to have, I'm a little snowed under with all kinds of work at the moment, but I'll add this to the todo list. It should be done near the end of the month. :smiley:

BaileyJM02 commented 4 years ago

Also, thank you for the kind message! :smiling_face_with_three_hearts:

MacDada commented 1 year ago

is it there, already?