search

Baizey / UniversalAutomaticCurrencyConverter

A currency converter for chrome and firefox which supports a large amount of currencies and can automatically convert websites
https://addons.mozilla.org/en-US/firefox/addon/ua-currency-converter/
36 stars 12 forks source link

Proper currency detection when ,- is used as currency #66

Open pekvasnovsky opened 5 months ago

pekvasnovsky commented 5 months ago

Hello,

I'm not sure whether this is even feasible but

at this website https://www.alza.cz/ you can see prices which are in czk but sometimes ",-" are used as replacement for currencies in some countries

but I assume it would not be that easy to autodetect proper currency for that symbol based on the website (maybe when they have some metadata filled out, or maybe based on domain? not sure here)

Baizey commented 4 months ago

Hi, I do actually have support for this, although I think it currently only assumes ,- is for Nordic countries

pekvasnovsky commented 4 months ago

I guess this would be where it is configured https://github.com/Baizey/UniversalAutomaticCurrencyConverter/blob/37065acafc54900a2edc2fdd7e9d9690872823a8/src/currencyConverter/Localization/Localization.ts#L25

I didn't look more into it, is there some way you also do some detection which one of these configured ones should be used?

I would also guess it might make sense to be configurable manually per "current domain" by clicking on the extension icon or via the context menu

I feel like ,- is used for more countries as a placeholder for "current country currency" so I would assume more websites from all over the world/europe might be encountered

Baizey commented 3 months ago

I was not aware that ,- was used as a general currency replacement, thought it was a nordic-countries shorthand.

There is a general system for handling these ambigious symbols that may be used in multiple currencies, but it's not made to scale up to possibly being any currency.

This may also just be something cz shares with the nordics, like the use of kr, in which case this would be a quick thing to fix :)

But I have also not been actively maintaining this repo for a long while (> 1 year?) so I wont promise the update is out anytime soon

pekvasnovsky commented 3 months ago

After really quick search I found out that it might be like: 50,00 can be written as 50,- indicating no decimals

but maybe it started that way but I bet a lot of people just used it for indicating either implicit currency or like indicating that the number written is the price

sources: https://www.reddit.com/r/NoStupidQuestions/comments/9v5vl1/why_is_a_comma_and_a_period_used_as_the_price/ https://boardgamegeek.com/thread/957754/whats-comma-dash

On Mon, Mar 25, 2024, 18:29 Lasse Spindler Mørk @.***> wrote:

I was not aware that ,- was used as a general currency replacement, thought it was a nordic-countries shorthand.

There is a general system for handling these ambigious symbols that may be used in multiple currencies, but it's not made to scale up to possibly being any currency.

This may also just be something cz shares with the nordics, like the use of kr, in which case this would be a quick thing to fix :)

But I have also not been actively maintaining this repo for a long while (> 1 year?) so I wont promise the update is out anytime soon

— Reply to this email directly, view it on GitHub https://github.com/Baizey/UniversalAutomaticCurrencyConverter/issues/66#issuecomment-2018531139, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCT6EG2EMZAEL3KHGA3RB7LY2BNGXAVCNFSM6AAAAABCTZ34KOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGUZTCMJTHE . You are receiving this because you authored the thread.Message ID: @.*** com>