BakhatBegum / My-Coursework-Planner

0 stars 0 forks source link

[TECH ED] Code Review A Colleague's TV Show Project #122

Open BakhatBegum opened 7 months ago

BakhatBegum commented 7 months ago

From Module-JS3 created by SallyMcGrath: CodeYourFuture/Module-JS3#10

Link to the coursework

https://github.com/CodeYourFuture/tv-show-dom-project

Why are we doing this?

Assignment: Complete a code review of a colleague's project.

You should by now have seen quite a few of your colleague's TV Show Projects. What project have you been most interested in? What solutions have you learned the most from? What lessons will you take into your own practice? You might have noticed:

Check out the Financial Times competency on Engineering Communication to understand why developing this skill is so important.

Maximum time in hours (Tech has max 16 per week total)

3

How to get help

Read the GitHub docs on reviewing pull requests

How to submit

Your submission should be in the form of a code review on a colleague's TV Show Project. Attach a link to this ticket.

Anything else?

https://syllabus.codeyourfuture.io/guides/code-style-guide

BakhatBegum commented 7 months ago

https://github.com/malkitbenning/tv-show-dom-project/pull/1#pullrequestreview-1479046414

BakhatBegum commented 7 months ago

https://github.com/fikretellek/JS3-Module-Project/commit/704b4ad6692f8a5fd1cb75425ad113ec4ba91bcf

JayMayer commented 6 months ago

Nice review @BakhatBegum