Auto Core pool list issues

Tritium-VLK commented 9 months ago

wjAURA has a dead rate provider and just needs to be blacklisted
Pools with less than 50% interest bearing tokens like the gold pools are appearing on the list.
Need to check delta with current list again and figure out differences

Need to be more careful when reintroducing.

We have reverted back to using the core pools list on multisig ops. The resulting list should match, and at best we should watch that it continues to match for a while before trying another cutover.

gosuto-inzasheru commented 8 months ago

ok so these pools are currently included in the manual core pools json, but not picked up by the automated process:

{
  "mainnet": {
    "0x70d5e3234f6329c1d5a26796dcf4e109d69a34880000000000000000000005e7": "uniETH/wstETH/rETH",
    "0xb3b675a9a3cb0df8f66caf08549371bfb76a9867000200000000000000000611": "ECLP-mevETH-wETH",
    "0x5f1f4e50ba51d723f12385a8a9606afc3a0555f5000200000000000000000465": "50wstETH-50LDO",
    "0x1ee442b5326009bb18f2f472d3e0061513d1a0ff000200000000000000000464": "50rETH-50BADGER",
    "0xe3e0022d25194431a98e8bf5034d2617c96e1d44000000000000000000000670": "instETH-wstETH",
    // "0x09b03b7cbb19b3dae94f884cf60dbc3c99a3947b00000000000000000000066c": "pyUSD/sDOLA BSP",
    // "0xff42a9af956617e4c3532ef2fc7567465efe4909000200000000000000000672": "50KEP/50rsETH",
    "0x6aa5a6b9257ca6e18b2da94e1a5fbe57ce2947ca00000000000000000000067b": "genETH/wstETH",
    "0xb91159aa527d4769cb9faf3e4adb760c7e8c8ea700000000000000000000067c": "ETHx/wstETH",
    "0x63e0d47a6964ad1565345da9bfa66659f4983f02000000000000000000000681": "pufETH/wstETH"
  },
  "arbitrum": {
    // "0x9f8ed1acfe0c863381b9081aff2144fc867aa7730002000000000000000004d4": "ANKR:ankrETH",
    "0xa1a8bf131571a2139feb79401aa4a2e9482df6270002000000000000000004b4": "wstETH:4pool",
    "0x4b3af34eb1135d59df8b9cdc2ff07d30d05334c400000000000000000000050d": "weETH/rETH",
    "0xca8ecd05a289b1fbc2e0eaec07360c4bfec07b6100020000000000000000051d": "2CLP-AUSDC-USDC",
    "0x14abd18d1fa335e9f630a658a2799b33208763fa00020000000000000000051f": "2CLP-AUSDT-USDT",
    "0x125bc5a031b2db6733bfa35d914ffa428095978b000200000000000000000514": "ECLP-AUSDC-AUSDT"
  },
  "zkevm": {
    "0xb1557cfea06de5a1601a7f0ccf3b515ef431a50d000200000000000000000059": "ECLP-wETH-rETH (OLD, to be killed)",
    "0x9f826c576b1f821df31ca6d58c9443db25a81d65000200000000000000000064": "ECLP-wETH-rETH (NEW)"
  },
  "base": {
    "0xfb4c2e6e6e27b5b4a07a36360c89ede29bb3c9b6000000000000000000000026": "cbETH/WETH"
  }
}

except for the commented ones (these have a bugged totalLiquidity in the subgraphs, see https://github.com/balancer/balancer-subgraph-v2/issues/579), all of these manually added pools are currently not reaching the $250k minimum liquidity limit

is a minimum liquidity of $250k really required? if so, why include pools that dont reach this threshold?

then, the following pools are currently picked up by the automated process but are not present in the manual core pools json:

{
  "mainnet": {
    "0x1cce5169bde03f3d5ad0206f6bd057953539dae600020000000000000000062b": "ECLP-GYD-sDAI",
    "0xdd59f89b5b07b7844d72996fc9d83d81acc8219600000000000000000000059e": "uniETH-WETH"
  },
  "arbitrum": {
    "0xc7fa3a3527435720f0e2a4c1378335324dd4f9b3000200000000000000000459": "55auraBal-45wsteth"
  },
  "optimism": {
    "0x004700ba0a4f5f22e1e78a277fca55e36f47e09c000000000000000000000104": "bpt-ankrgalaharm",
    "0x4fd63966879300cafafbb35d157dc5229278ed2300020000000000000000002b": "BPT-rETH-ETH",
    "0x5f8893506ddc4c271837187d14a9c87964a074dc000000000000000000000106": "bpt-ethtri",
    "0x7ca75bdea9dede97f8b13c6641b768650cb837820002000000000000000000d5": "ECLP-wstETH-WETH",
    "0xc1f46ce83439886f0ea9c21512b36e7e67239d2c000200000000000000000108": "bpt-roabee"
  },
  "gnosis": {
    "0x06135a9ae830476d3a941bae9010b63732a055f4000000000000000000000065": "stEUR/EURe",
    "0x7644fa5d0ea14fcf3e813fdf93ca9544f8567655000000000000000000000066": "sBAL3",
    "0xdd439304a77f54b1f7854751ac1169b279591ef7000000000000000000000064": "EURe/sDAI"
  }
}

so the issue we had with switching too early to the automated json now also applies backwards: all the pools mentioned above should be in the manual core pools json. i set up a pr for this: https://github.com/BalancerMaxis/multisig-ops/pull/881

gosuto-inzasheru commented 8 months ago

TODO: add (alphabetical) sorting, to minimise diffs

Tritium-VLK commented 7 months ago

Lower liq threshold to 100k Only exceptions Next round run diff between 2 lists and then if everyone agrees switch config on the fee_allocator if it looks good.

Make sure to remind people to crosscheck for at least 4-5 rounds.

BalancerMaxis / bal_addresses

Auto Core pool list issues #214