search

BalancerMaxis / bal_tools

1 stars 0 forks source link

Add classes to handle W3_RPC #27

Closed Tritium-VLK closed 1 month ago

Tritium-VLK commented 1 month ago

Use dRPC right now as it's super easy, but this creates an interface that is easy to change in 1 place. See: https://github.com/BalancerMaxis/bal_addresses/pull/383

For a test of these classes, I don't think bal_addresses can actually use them due to the dependancy conflict, so maybe this belongs there?

Tritium-VLK commented 1 month ago

Fraxtal is missing from dRPC. Challenging them to see how such a thing is dealt with.

Tritium-VLK commented 1 month ago

tagged: https://github.com/BalancerMaxis/bal_tools/releases/tag/v0.1.2alpha1 bal_addresses tag to use it: https://github.com/BalancerMaxis/bal_addresses/releases/tag/0.9.9alpha1 test pr using tag: https://github.com/BalancerMaxis/protocol_fee_allocator/pull/239 test action run: https://github.com/BalancerMaxis/protocol_fee_allocator/actions/runs/10115157857/job/27975300430

Tritium-VLK commented 1 month ago

Next step is to approve/release bal_tools. Then deal with questions about where the canonical list pools to check permissions lives on in the bal_addresses pr and merge/release that. Then release new releases, update the protocol_feel_allocator.

jalbrekt85 commented 1 month ago

nice, simple to use class for web3 instances across all chains. added some very basic tests. lgtm

gosuto-inzasheru commented 1 month ago

new test is not being run:

collected 94 items

tests/test_drpc.py ss                                                    [  2%]
tests/test_pools_gauges.py ..ss.s.s.ss.s.s.ss.s.s.ss.s.s.ss...s.ss.s.s.s [ 50%]
s.s.s.ss.s.s.ss.s.                                                       [ 69%]
tests/test_safe_tx_builder.py .                                          [ 70%]
tests/test_subgraph.py s.s.s.s.s.s.s.s.s......                           [ 94%]
tests/mock/test_mock_subgraph.py .....                                   [100%]

================== 49 passed, 45 skipped in 142.[59](https://github.com/BalancerMaxis/bal_tools/actions/runs/10119623674/job/27988323246?pr=27#step:6:60)s (0:02:22) ==================
jalbrekt85 commented 1 month ago

new test is not being run:

collected 94 items

tests/test_drpc.py ss                                                    [  2%]
tests/test_pools_gauges.py ..ss.s.s.ss.s.s.ss.s.s.ss.s.s.ss...s.ss.s.s.s [ 50%]
s.s.s.ss.s.s.ss.s.                                                       [ 69%]
tests/test_safe_tx_builder.py .                                          [ 70%]
tests/test_subgraph.py s.s.s.s.s.s.s.s.s......                           [ 94%]
tests/mock/test_mock_subgraph.py .....                                   [100%]

================== 49 passed, 45 skipped in 142.[59](https://github.com/BalancerMaxis/bal_tools/actions/runs/10119623674/job/27988323246?pr=27#step:6:60)s (0:02:22) ==================

fixed in 0f40f08

Tritium-VLK commented 1 month ago

@jalbrekt85 @gosuto-inzasheru thanks for the help. Will merge this and release a new version.