search

BalancerMaxis / protocol_fee_allocator_v2

0 stars 0 forks source link

Do not 0 out/redirect earned if fees are redirected #10

Open Tritium-VLK opened 2 weeks ago

Tritium-VLK commented 2 weeks ago

In protocol allocator V1, if rewards are redirected, the earned is not. It seems like in V2, the earned is being changed in the redirect logic. This makes it hard to compare.

Earned should always show how much the pool earned. The redirect should work by redirect incentives from pools that didn't earn enough to pools that did. It should be easy to see how much a pool earned and that it didn't earn enough/how much it needed to earn/etc.

jalbrekt85 commented 2 weeks ago

In protocol allocator V1, if rewards are redirected, the earned is not. It seems like in V2, the earned is being changed in the redirect logic. This makes it hard to compare.

the total_earned_fees_usd is not being changed in the redirect logic