Balastrong / myntenance

Your next side project won't fail this time 💡
https://myntenance.vercel.app
11 stars 10 forks source link

Implement Deletion Confirmation and Loading Spinner (#24, #25) #34

Closed ZeeshanMukhtar1 closed 2 months ago

ZeeshanMukhtar1 commented 2 months ago

PR Description:

This pull request addresses two user experience improvements for the delete repository functionality:

  1. Confirmation Modal for Deletion:
    • Introduces a confirmation modal that prompts the user to verify their intention before permanently deleting a repository. This adds a crucial safety measure to prevent accidental deletions. (Issue #24)
  2. Loading Spinner for Deletion:
    • Implements a loading spinner that displays while the deletion process is in progress. This provides visual feedback to the user, indicating that the action is being processed. (Issue #25)

Testing Instructions:

  1. Navigate to the "Delete Repository" page.
  2. Click the "Delete" button. ( red btn in danger zone
  3. Verify that a confirmation modal appears, prompting you to confirm deletion.
  4. Click "Continue" to proceed with deletion.
  5. Observe the loading spinner while the deletion is in progress.
  6. Once deletion is complete, verify that appropriate feedback is displayed (e.g., success message from sooner).

Fixes:

Benefits:

@mentions:

vercel[bot] commented 2 months ago

@ZeeshanMukhtar1 is attempting to deploy a commit to the balastrong's projects Team on Vercel.

A member of the Team first needs to authorize it.

Balastrong commented 2 months ago

Hey, thanks for the PR!

I'm sorry but there's already another one fixing the same issue (see #30) so I'm gonna close this one.

Feel free to review the other PR and add feedback if you have :)