Baldhor / Homey-ESPhome-Enhanced

This is an Homey app which adds support for ESPHome devices. ESPHome is a system to control your ESP8266/ESP32 by simple yet powerful configuration files and control them remotely through Home Automation systems. More information on their homepage: https://www.esphome.io/
GNU General Public License v3.0
4 stars 3 forks source link

Improved UI #30

Closed Baldhor closed 8 months ago

Baldhor commented 10 months ago

Is your feature request related to a problem? Please describe. To be honest, the Wizard is looking just bad ... I tried using the homey css style, but the result is just not good.

Describe the solution you'd like I'm thinking about using https://github.com/vuejs/petite-vue. Try to obtain a result looking like HomeKitty: image

Basically it means:

Additional features At the same time, I think the wizard should allow to match a native capability to several capabilities. Within a single virtual device or not => the wizard should give a warning, but not an alert (blocking). However, the same native capability should not be matched several times on the same capability "on a single virtual device".

Examples: 1/ The cover position is used as windowcoverings_set capability. If "also" matched to a number capability, it could be used to indicate the " %" as a state indicator.

2/ The status of the physical device could be matched to a capability on every virtual device Same for wifi status ...

Baldhor commented 9 months ago

Just a short pick at the state of the improved UI: image

Work is in progress for the virtual device list.

RoadXY commented 9 months ago

Nice work, well done!

Could the first screen have explanation, right below the button 'List of physical devices', in the red box (see screenshot below)? Suggestion for explanation text: If you want to add a new physical device, use 'List of virtual device'.

A physical device is the device it self and can contain one or more virtual devices. This way you can split up your device for Homey when you have, for example, a ESPHome device which controls the roller shutters AND has a temperature and humidity sensor connected to it.

image

Baldhor commented 9 months ago

@RoadXY Well the new version of the wizard will allow even more. Usually with homey : ONE "homey" device is ONE physical device. The current implementation of ESPhome app allows : SEVERAL "homey" devices are linked to ONE physicial device Improved UI will make it one step further : SEVERAL "homey" deviced can be linked to SEVERAL physical devices, AND the same physical device capability can be used several times for different purpose (within the same"homey" device or not) !

Let's for exemple consider a cover, the position state could be used for the windowcoverings_set capability, but also as "measure_current" with unit defined as "%". The result could be something like: image

You can also imagine to use a capability "measure_poàwer" in "kWH" with precision of 0 (for main page) and another with precision of 3 for a more detailed measure ...

Talking about enhancement request #39, the same native capability could be matched to a "cumulative capability" and a "not cumulative capability".

You can imagine a device which list the wifi status of all your ESPhome devices.s

Anyway, I'm very unsure what peoples will do with it, I just do not see any reason to limit it.

Baldhor commented 9 months ago

I plan a wiki page with pictures to explain the different screens and what they can do.

Baldhor commented 9 months ago

List of virtual device and new physical device are implemented: image

No idea why but I just cannot retrieve the zone of a device ... getDevices()[0].zoneName or zone returns undefined ...

Connection to the new physical device or failure to do so are fully functionnal (including timeout). image

Next step is the ability to edit a virtual device, which is going to be hard work ...

Baldhor commented 9 months ago

Renamed the main menu choice, and reviewed the "Manage your virtual devices" view

image image

Baldhor commented 9 months ago

New virtual device view is implemented and functionnal: image

Next steps:

Baldhor commented 9 months ago

So I'm fully blocked at the moment because of a strange bug in petite-vue:

VM20:1 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'insertBefore')
    at ze (<anonymous>:1:10577)
    at De (<anonymous>:1:12721)
    at Ge (<anonymous>:1:13472)
    at De (<anonymous>:1:13423)
    at new nt (<anonymous>:1:15203)
    at $ (<anonymous>:1:11192)
    at W.fn (<anonymous>:1:11670)
    at W.run (<anonymous>:1:2309)
    at me (<anonymous>:1:6108)

Spent too many hours on it already ... I oversee only 2 solutions: 1/ Reorganize everything as components, but no idea if it will make the issue disappear 2/ Remove petite-vue ...

Baldhor commented 9 months ago

found the root cause of the bug ... moving on

Baldhor commented 9 months ago

Working on the capability page (add / edit), it's about 50% done (see below). It's just missing the input fields to set the capability options, should be straigh forward.

Then it will remains:

image

Baldhor commented 9 months ago

Capability page fully implemented, see below. Tested at 90%, a few bugs left probably.

I added a "hide or show" ability for native capability configs and constraints. It helps keep the page smaller.

image

RoadXY commented 9 months ago

Wow, nice work! 👍

Baldhor commented 9 months ago

A proof it works :) image

RoadXY commented 9 months ago

Nice 👍 Can't wait to try it out!

Baldhor commented 9 months ago

Capability page is fully tested and functionnal. Just need clean up physical device if they become useless :)

Remaining tasks:

  1. Update processing (when your physical device's native capabilities change!) => just need to pick the existing code
  2. Ability to save an edited virtual device => easy
  3. Ability to delete a capability or a virtual device => easy (hopefully homey api work out as expected :) )
  4. A welcome page to explain the changes and point to the FAQ => easy
  5. A FAQ to explain how that crazy thing works ...
Baldhor commented 8 months ago

Implemented ability to modify the name, zone and class of a device. see below ...

However: Modification of the name and zone require to go through the Web API, which require your bearer token.

It means I will need to allow setting YOUR bearer token in the app setting screen, and until you do so, the name and zone fields will be "locked". So I need to implement a "lock" functionnality (how cool).

Thanks Athom BV engineers for your great api consistency ...

image

Baldhor commented 8 months ago

Deletion of virtual device implemented, see below. /!\ require bearer token!

image

RoadXY commented 8 months ago

Nice! How do you acquire an bearer token?

Baldhor commented 8 months ago

Nice! How do you acquire an bearer token?

@RoadXY That's the main issue :

  1. Go to : https://my.homey.app/
  2. Press F11 (or F12 depends of your browser) to open the developper tool
  3. Go to network tab
  4. Look for a request with the bearer token in its headers

See pictures As you can imagine, many users will have issues to find it ... edit: and the token change "often" (like once every 2 weeks hopefully, but maybe less)

image

Baldhor commented 8 months ago

Deletion of capability is implement.

Added ability to input a bearer token:

  1. Not saved: the user need to input it everytime he wants to access "advanced" functionnalies
  2. Advanced functionnalities are: -- Modification of a virtual device name or zone -- Creation of a virtual device in a specific zone, by default it will go into curent zone -- Deletion of a virtual device directly from the wizard

image

Baldhor commented 8 months ago

@RoadXY I will publish 1.0.0 as beta version if you are willing to test it out :) Please note:

I will not publish officialy until the welcome pages and a FAQ/Wiki is ready.

Baldhor commented 8 months ago

1.0.0 is published FOR TEST PURPOSE: https://homey.app/a/nl.inversion.esphome/test/ This thread is closed, please open new issues if you have the courage to test it out :)

Baldhor commented 8 months ago

Started a guide: https://github.com/Baldhor/Homey-ESPhome-Enhanced/wiki/About-release-1.0.0

RoadXY commented 8 months ago

Nice! How do you acquire an bearer token?

@RoadXY That's the main issue :

  1. Go to : https://my.homey.app/
  2. Press F11 (or F12 depends of your browser) to open the developper tool
  3. Go to network tab
  4. Look for a request with the bearer token in its headers

See pictures As you can imagine, many users will have issues to find it ... edit: and the token change "often" (like once every 2 weeks hopefully, but maybe less)

image

The Homey Pro 2023 has an option for creation of an API key local. The previous models, however, dont. https://community.homey.app/t/app-pro-dashboards-custom-dashboards-for-your-homey/84837/2?u=robin_van_kekem