Baldhor / Homey-ESPhome-Enhanced

This is an Homey app which adds support for ESPHome devices. ESPHome is a system to control your ESP8266/ESP32 by simple yet powerful configuration files and control them remotely through Home Automation systems. More information on their homepage: https://www.esphome.io/
GNU General Public License v3.0
5 stars 3 forks source link

Support for Nettop custom enum #66

Closed Baldhor closed 1 year ago

Baldhor commented 1 year ago

@Nettopp helped test many functions, let implement all the custom enum he need for his climate device :)

I need your "collect device info" for your climate device. I'm pretty sure you posted it somewhere, but just cannot find it anymore :) https://github.com/Baldhor/Homey-ESPhome-Enhanced/wiki/User-Guide#manage-your-physical-devices-page

Nettopp commented 1 year ago

@Baldhor Yay! Here is the debug log: Debug info.txt

Baldhor commented 1 year ago

@Nettopp A few questions :)


Custom Fan mode:

      {
        "nativeCapabilityId": "290099816:customFanMode",
        "entityId": "290099816",
        "attribut": "customFanMode",
        "entityName": "Panasonic AC",
        "type": "Climate",
        "used": 1,
        "value": "Automatic",
        "configs": {},
        "constraints": {
          "values": [
            "1",
            "2",
            "3",
            "4",
            "5",
            "Automatic"
          ],
          "type": "string"
        },
        "specialCase": null
      },

Usefull? Which values you would expect (1, 2, 3, ...) is not very meaningfull :)


Swing mode list:

          "supportedSwingModesList": [
            0,
            1,
            2,
            3
          ],

Usefull? I think not, you are using horizontal swing mode and vertical swing mode!


I will add a custom enum capability for:

Nettopp commented 1 year ago

Usefull? Which values you would expect (1, 2, 3, ...) is not very meaningfull :)

Fan mode equals fan speed, from 1 (lowest) to 5 (highest), and auto. Its the same settings as the remote, no need to change this in my opinion.

Swing mode list:

          "supportedSwingModesList": [
            0,
            1,
            2,
            3
          ],

Usefull? I think not, you are using horizontal swing mode and vertical swing mode!

You are correct, swing mode is not in use for my heat pump. Vertical and horizontal takes its place.

I will add a custom enum capability for:

  • [ ] Panasonic AC Vertical Swing Mode
  • [ ] supportedCustomPresetsList
  • [ ] supportedCustomFanModesList (if you need it)
  • [ ] supportedSwingModesList (if you need it, but I don't think so)

Sounds good! You do not need to add swing mode, but fan mode would be great :) It would also be great if you could add mode (heat, cool, off, etc). That would be super useful.

Baldhor commented 1 year ago

It would also be great if you could add mode (heat, cool, off, etc). That would be super useful.

You are right, I added horizontal swing mode, stil lneed mode lol => the most important :)

Baldhor commented 1 year ago

@Nettopp done: https://homey.app/fr-fr/app/nl.inversion.esphome/ESPhome/test/

If I did it right:

Happy testing :)

Nettopp commented 1 year ago

@Baldhor Great, I'm currently testing! I did not get an option for custom enum on "mode", is this implemented?

image

Baldhor commented 1 year ago

I did not get an option for custom enum on "mode", is this implemented?

Yes, and I cannot find any reason it wouldn't work out.

What about the 3 others ? fan_mode, vertical_swing and custom preset?

Baldhor commented 1 year ago

@Nettopp Found the issue for mode : https://homey.app/fr-fr/app/nl.inversion.esphome/ESPhome/test/

Baldhor commented 1 year ago

For info, I added a 'Custom Enum Request' type of issue for further needs: Custom Enum Request

Some peoples will not like it, but I'm asking for a beer in exchange!

Nettopp commented 1 year ago

@Baldhor Testing on 1.1.27, everything looks to be in order. All custom enums are there now, including mode. I have not testet every action card yet, but will try to make some flows over the weekend.

Charging for custom enums is very fair in my opinion, I came from Homeseer where you had to pay for most third party plugins (they were not cheap either). I sent you a tip last week, thank you for all your work with the climate component!

Baldhor commented 1 year ago

Time to close this thread!