search

Baldinof / roadrunner-bundle

A RoadRunner worker integrated in your Symfony app
MIT License
255 stars 46 forks source link

feat: add sentry-sdk ^4.0 support #141

Closed WaylandAce closed 2 months ago

WaylandAce commented 2 months ago

Closes https://github.com/Baldinof/roadrunner-bundle/issues/140

bitgandtter commented 2 months ago

@WaylandAce i need this update as well. i can help if you give me access to your fork/repo

Baldinof commented 2 months ago

@bitgandtter If you want to do another PR that use instanceof I will accept it

WaylandAce commented 2 months ago

Applied suggestion.

Baldinof commented 2 months ago

It needs the use too

bitgandtter commented 2 months ago

@WaylandAce that needs to be applied to the listener as well

    public function onWorkerStop(WorkerStopEvent $event): void
    {
        $result = $this->hub->getClient()?->flush();
        if ($result instanceof GuzzleHttp\Promise\PromiseInterface) {
            $result->wait(false);
        }
    }
bitgandtter commented 2 months ago

@Baldinof can you review?

Baldinof commented 2 months ago

It's released as 3.1.1.

Thank you for the PR @WaylandAce