Baldinof / roadrunner-bundle

A RoadRunner worker integrated in your Symfony app
MIT License
270 stars 48 forks source link

Must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface #41

Closed treadmillian closed 3 years ago

treadmillian commented 3 years ago

Hi,

Is there an issue using Symfony 4.4.24 and PHP 7.4 with the ^2.0 release?

Thanks, Kevin

Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  Cannot load Xdebug - it was already loaded
!!  
!!  Fatal error: Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true) in /Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php on line 67
!!  PHP Fatal error:  Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true) in /Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php on line 67
!!  Symfony\Component\ErrorHandler\Error\FatalError {#10011
!!    -error: array:4 [
!!      "type" => 64
!!      "message" => "Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true)"
!!      "file" => "/Users/ks27/code/smt/vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php"
!!      "line" => 67
!!    ]
!!    #message: "Compile Error: Declaration of Baldinof\RoadRunnerBundle\Http\Runner::handle(Symfony\Component\HttpFoundation\Request $request, int $type = self::MASTER_REQUEST, bool $catch = true): Symfony\Component\HttpFoundation\Response must be compatible with Symfony\Component\HttpKernel\HttpKernelInterface::handle(Symfony\Component\HttpFoundation\Request $request, $type = self::MASTER_REQUEST, $catch = true)"
!!    #code: 0
!!    #file: "./vendor/baldinof/roadrunner-bundle/src/Http/MiddlewareStack.php"
!!    #line: 67
!!  }
!!  
Script @auto-scripts was called via post-update-cmd

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
Baldinof commented 3 years ago

Hi, you are right, currently it's not working :(

I will try to have a look on it. And to understand why the CI installed Symfony 5 when using lowest deps here https://github.com/Baldinof/roadrunner-bundle/runs/2365909602?check_suite_focus=true#step:6:111

dhopkalo commented 3 years ago

Today got the same issue, and right now it fixed :) will wait for the merge and release the bug fix version

Baldinof commented 3 years ago

The fix is released as v2.0.2, can you confirm it's working for you?

dhopkalo commented 3 years ago

@Baldinof thanks for the flash fix :), tested all works as expected.

treadmillian commented 3 years ago

@Baldino Thank you for fixing so quickly.