search

Baldinof / roadrunner-bundle

A RoadRunner worker integrated in your Symfony app
MIT License
255 stars 46 forks source link

Sentry Tracing #67

Closed iborysenko closed 1 year ago

iborysenko commented 2 years ago

Sentry ^4.1 has the ability to use tracking feature 

sentry:
  #.....
  tracing:
    enabled: true
    dbal:
      enabled: true
    cache:
      enabled: false

But by default Sentry finish the transaction onKernelTerminate so I changed it to onKernelResponse using decoration

Baldinof commented 2 years ago

Hi!

So when the tracing transaction should be finnished then?

iborysenko commented 2 years ago

Hi, @Baldinof

So, now tracing transaction duration from onKernelRequest to onKernelResponse

Default behavior from onKernelRequest to onKernelTerminate, but onKernelTerminate occurs only if use reboot kernel after each request

voskobovich commented 1 year ago

@iborysenko Hi!

Do you plan to fix the conflicts?

iborysenko commented 1 year ago

Hi @voskobovich, I missed this PR, because I'm using forked Repo

I fixed all conflicts, but now CI did not allow me to use both definitions service('.inner') OR service(TracingRequestListener::class. '.inner')

I'm a strong hater of this service definition method (php files), Maybe @Baldinof can help with this, or I will define decoration in the Extension file tomorrow.

Baldinof commented 1 year ago

👋 I think that's because the SentryBundle is not always registered, so yes I guess it would be better to register it here: https://github.com/Baldinof/roadrunner-bundle/blob/4e4997ed3c69dadbe36322672ce9389ce53d488c/src/DependencyInjection/BaldinofRoadRunnerExtension.php#L136

voskobovich commented 1 year ago

@Baldinof When do you plan the next release with this feature?

Baldinof commented 1 year ago

@voskobovich I just released 2.3.1, can you confirm it's working for you?