search

BaldissaraMatheus / Tasks.md

A self-hosted, Markdown file based task management board
https://hub.docker.com/r/baldissaramatheus/tasks.md
MIT License
461 stars 15 forks source link

Allow arbitrary environment #69

Closed orhtej2 closed 5 months ago

orhtej2 commented 5 months ago

While I understand target audience is supposed to run via Docker there's no technical reason why the directory where data is stored and port the app is listening on are not sourced from process.env.

This would allow bare metal hosting at no cost to app's maintainability.

BaldissaraMatheus commented 5 months ago

Yes, you're right. It requires a small change so I'll work on it as soon as possible

BaldissaraMatheus commented 5 months ago

Hey @orhtej2, I included this change in #73. Can you confirm if it works for you?

BaldissaraMatheus commented 5 months ago

This change was included by https://github.com/BaldissaraMatheus/Tasks.md/pull/73 so I'll close this issue. If someone thinks it's not working properly or could be improved, feel free to comment here and I'll open the issue again.

orhtej2 commented 5 months ago

Hi, thanks for that, I did not have the time to test bare metal deployments yet but the change looks OK!

TY for implementing this :)

On Mon, Feb 12, 2024 at 3:13 PM Matheus Baldissara @.***> wrote:

This change was included by #73 https://github.com/BaldissaraMatheus/Tasks.md/pull/73 so I'll close this issue. If someone thinks it's not working properly or could be improved, feel free to comment here and I'll open the issue again.

— Reply to this email directly, view it on GitHub https://github.com/BaldissaraMatheus/Tasks.md/issues/69#issuecomment-1938757647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV5D5RD2GDT5I7JHGCDE5DYTIPR5AVCNFSM6AAAAABCYH4G5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYG42TONRUG4 . You are receiving this because you were mentioned.Message ID: @.***>