Baldomo / asusctltray

Simple tray profile switcher for asusctl
MIT License
33 stars 5 forks source link

Wrap the project into a namespace for easy killing on WM reset #18

Closed bhalalansh closed 3 months ago

bhalalansh commented 1 year ago

Can anyone step up and make it possible to wrap the project in a namespace so that it can be easily killed when the window manager users reload the window manager (pkill asusctltray). And/OR optionally allow only one instance to run at a time?

Baldomo commented 1 year ago

Sure, I can implement instance checking fairly easily, but what do you mean by "namespace"? I don't suppose you're referring to Linux process namespaces because I can't see how those would be influenced by a window manager. If you'd like to give more info on that, we could try working out a solution.

bhalalansh commented 1 year ago

So basically what I am talking is how there is other applications that keep put in the appindicator (trayicons) usually have like this namespace(linux process name) which when you use

pkill <appname>

the app (the appindicator) will shutoff, which is not the case for this project. It shows only one thing: "python3" or "python" (as the process name).

So in short it shalt have a process name.

bhalalansh commented 1 year ago

So for example here is leftwm's example for how they kill the custom trayicon stuff on reload and then start them on the end of reload:

fairly they have two files, namely up and down

up: https://github.com/AethanFoot/leftwm-theme-dracula-rounded/blob/master/up

(they start processes with specific name like dunst, picom, polybar)

down: https://github.com/AethanFoot/leftwm-theme-dracula-rounded/blob/master/down

(they kill processes with specific name like dunst, picom, polybar)

while the asusctltray project just have its process ran as a python3 runtime, rather than having its own namespace.

bhalalansh commented 1 year ago

Actually this might be quite easy, as i saw this: https://code.google.com/archive/p/procname/

Baldomo commented 1 year ago

Sorry for the late response! Sure, I can work something out for that, but I'm going to treat as a low priority issue because I feel like this is more cosmetic than anything (since changing the process name is basically hacking around the Linux process namespaces working correctly). I'll work on it in the next couple days and report back.

bhalalansh commented 1 year ago

Alright

Baldomo commented 3 months ago

Sorry, it's been quite a while. I have had time ti investigate this and I don't think it will ever be implemented. others are welcome to try bu this is a purely cosmetic issue. Feel free to reopen it in the future