bug: open-in-mpv can not read config

[ghost]

Bug Description

Hi, I installed open-in-mpv with git clone and sudo make install , make install-protocol. I created a config file which is ~/.config/open-in-mpv/config.yml I also added it to /etc/xdg/open-in-mpv/ I also changed the configuration file before doing sudo make install , make install-protocol but problem is still, when I click the open-in-mpv on firefox to some youtube links it does not read my configuration file. I even tried install with precompiled binaries

How to Reproduce

Steps to reproduce the behavior:

1. Go to 'youtube.com'
2. Click on 'open-in-mpv'
3. Do 'wait'
4. See 'default settings'

Expected Behavior

I expected to execute umpv which is executable script for mpv, it makes mpv unique application so I can add videos to playlist with open-in-mpv extension, without having more mpv tabs, also it is expected to open mpv in fullscreen

Version

firefox extension version 2.1.0 and app version 2.1.0

Configuration

players:
  mpv:
    name: mpv
    executable: umpv
    fullscreen: "--fs"
    pip: ""
    enqueue: "--enqueue"
    new_window: ""
    needs_ipc: true
    supported_protocols: ["http", "https"]
    flag_overrides: {}

Relevant log output (optional)

No response

What browsers are you seeing the problem on? (optional)

Firefox-based (Librewolf, Iceraven, etc.)

Checklist:

• [X] I have checked for existing issues that describe my problem prior to opening this one.
• [X] I understand that improperly formatted bug reports may be closed without explanation.

[Baldomo]

From the explanation you gave sounds like you may want to use the "enqueue" functionality that's already present in the default configuration, and taking a look at the umpv script it basically does what this program already implements (using the IPC socket to send files to the queue). Have I understood correctly?

[ghost]

Yes, but as I said above could not get it work.

[Baldomo]

Have you set the default open action to "Enqueue" in the extension settings?

Also, looking at your configuration you set needs_ipc to true but that will try sending the file to the IPC socket instead of the command line, which umpv expects. Could you try disabling needs_ipc?

[ghost]

ah yeah disabling needs_ipc worked thanks!