Baldomo / open-in-mpv

Simple web extension to open videos in mpv
GNU General Public License v3.0
119 stars 7 forks source link

bug: Launching with Celluloid launches both mpv and celluloid #21

Open yigib opened 1 year ago

yigib commented 1 year ago

Bug Description

Choosing Celluloid as the player and clicking the icon results in both mpv and Celluloid launching, both playing the video.

How to Reproduce

Steps to reproduce the behavior:

  1. Go to settings and choose Celluloid
  2. Open any youtube video
  3. Click on the extension icon
  4. See both players launching

Expected Behavior

Only celluloid should be launching.

Version

nightly (master branch)

Configuration

players:
  mpv:
    name: mpv
    executable: mpv
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: ""
    new_window: ""
    needs_ipc: true
    flag_overrides: {}
  celluloid:
    name: Celluloid
    executable: celluloid
    fullscreen: ""
    pip: ""
    enqueue: "--enqueue"
    new_window: "--new-window"
    needs_ipc: false
    flag_overrides: 
      "*": "--mpv-%s"
  mpvnet:
    name: mpv.net
    executable: mpvnet.exe
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: "--queue"
    new_window: ""
    needs_ipc: false
    flag_overrides: {}

Relevant log output (optional)

No response

What browsers are you seeing the problem on? (optional)

No response

Checklist:

Baldomo commented 3 months ago

After some testing, I could not reproduce this bug. Does it still happen on newer versions?