Baldomo / open-in-mpv

Simple web extension to open videos in mpv
GNU General Public License v3.0
119 stars 7 forks source link

Browser extensions will not open MPV on PopOS. #27

Open robbhimself opened 8 months ago

robbhimself commented 8 months ago

Bug Description

On PopOS with both chrome and firefox, the extension will not open mpv. The xdg-open dialog box appears and you click "open in open-in-mpv" and nothing happens.

mpv works fine from terminal and playing youtube videos with mpv+yt-dlp works fine.

How to Reproduce

Steps to reproduce the behavior:

  1. Go to 'youtube'
  2. Click on 'open in mpv from the extension menu or the right click menu
  3. Click "open in open-in-mpv" from the xdg-open dialog
  4. See 'nothing happens :('

Expected Behavior

Open mpv when you click "open in open-in-mpv" from the xdg-open dialog

Version

2.2.0

Configuration

players:
  mpv:
    name: mpv
    executable: mpv
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: ""
    new_window: ""
    needs_ipc: true
    flag_overrides: {}

Relevant log output (optional)

ive tried the precompiled binaries and compiled from git, the install-protocol.sh copies files to the right paths. Just nothing happens when the browser calls mpv.

What browsers are you seeing the problem on? (optional)

Firefox-based (Librewolf, Iceraven, etc.), Chromium-based (Brave, Chrome, etc.)

Checklist:

robbhimself commented 8 months ago

seems to work fine if mpv is already open, but it will not launch mpv

Baldomo commented 8 months ago

Thank you for the bug report. It makes sense that everything works when mpv is open, since the binary sends commands through the player's IPC interface. I will look into why the player isn't launched.