Baldomo / open-in-mpv

Simple web extension to open videos in mpv
GNU General Public License v3.0
119 stars 7 forks source link

Add keyboard shortcut for default action #33

Open Aethlas opened 2 months ago

Aethlas commented 2 months ago

Description

Added the option to set keyboard shortcut through either text in options page (Firefox only) or through browser "manage keyboard shortcuts".

Shortcut changes in the browser will reflect the text box in options and vice-versa, but it recommended to set it through the browser since you have all those default keybinding checks included. Only Firefox supports changing keyboard shortcuts dynamically (via commands.update() ), due "security concerns" you have to set it through chrome://extensions/shortcuts in Chrome. However, I kept the text box in, since it works on FF.

There should be no breaking change, but I have tested it on Firefox only.

Type of change

Checklist