search

Bali10050 / Lightly

A modern style for qt applications.
Other
105 stars 7 forks source link

Adding bottom line as option #20

Open ams-sth opened 1 month ago

ams-sth commented 1 month ago

A request to add a line pointed by red arrow. IMO, it feels feels incomplete without it.

Line Separator

Bali10050 commented 1 month ago

I have no idea how to do it, but I'll add it when I can

ams-sth commented 1 month ago

Sure. I will try from my side as well.

tduck973564 commented 1 month ago

This line should span the whole footer. It just looks worse on the Accessibility KCM because they're not actual sub-pages like the other settings are.

ams-sth commented 1 month ago

@tduck973564 Do you mean like shown in image ? I actually want to make it look like shown in image. Currently, I haven't been successful implementing in source code since I am no expert in cpp. The line shown in image occurs when I change application style and revert back to lightly but do not perform minimize and maximize activity or reopen system settings.

image

tduck973564 commented 1 month ago

@tduck973564 Do you mean like shown in image ? I actually want to make it look like shown in image. Currently, I haven't been successful implementing in source code since I am no expert in cpp. The line shown in image occurs when I change application style and revert back to lightly but do not perform minimize and maximize activity or reopen system settings.

Yes, that's what I mean. It just doesn't look as odd in the other sub-menus because, in those, the footer only spans the actual settings page.

ams-sth commented 1 month ago

Can you tell me which line of code should I alter to achieve that outcome ?

tduck973564 commented 1 month ago

If I knew I wouldn't be commenting here 😁

DeltaCopy commented 1 month ago

The line shown in image occurs when I change application style and revert back to lightly but do not perform minimize and maximize activity or reopen system settings.

I can repro this strange behavior too. Breeze, Fusion, Kvantum renders the border line above the buttons just fine.

Further investigation is indeed required.

christiantosta commented 2 weeks ago

Personally I prefer to remove the other lines, like kvantum does. But how to do it? Perhaps setting it color to the same as window background? Brise (not Breeze, but the fork) have a patch to made this lines less visible.

ams-sth commented 2 weeks ago

@christiantosta Yeah removing other lines also work. It will make design look consistent.

DeltaCopy commented 3 days ago

@ams-sth see #38 which is merged into feature/qt-6 branch and see if this helps with rendering the bottom line inside systemsettings.

ams-sth commented 3 days ago

@DeltaCopy Sure. I will give it a go. Update: It worked. There's now a thin line at the bottom of system setting.