search

Bali10050 / Lightly

A modern style for qt applications.
Other
111 stars 7 forks source link

QDialogButtonBox frame rendering #38

Closed DeltaCopy closed 2 weeks ago

DeltaCopy commented 2 weeks ago

These are experimental changes.

So would advise for now keeping this in the feature/qt6 branch until tested properly.

I think I've finally figured out how to fix https://github.com/Bali10050/Lightly/issues/20

The bottom line which we are supposed to see is a QDialogButtonBox that is where the buttons "Apply", "Reset", "Help" are meant to be contained in.

The systemsettings src code for reference shows: https://invent.kde.org/plasma/systemsettings/-/blob/master/app/ModuleView.cpp?ref_type=heads#L169

A comparison of the Breeze code shows multiple references to QDialogButtonBox; missing in Lightly.

This explains why it doesn't display properly not only on the Accessibility page, but also on the landing page of systemsettings as well as on other pages.

After making several changes it looks like this now.

landing access

DeltaCopy commented 2 weeks ago

Tested on fully up to date systems on Arch and Fedora 40

Bali10050 commented 2 weeks ago

Thank you!