Bali10050 / Lightly

A modern style for qt applications.
Other
111 stars 7 forks source link

Menubar opacity and toolbar colors #46

Closed DeltaCopy closed 1 week ago

DeltaCopy commented 1 week ago

This should close (potentially) #43 and #42

If this is merged please note the following.

The feature-qt6 branch will contain changes for #20, #43 and #42


43 Menubar transparency

Tested using the Glassly and Glassly-Darker theme https://store.kde.org/p/1652008

Changes made:

config

Kate now shows a full transparent menubar

kate


42 Make toolbar use darker gray tone

Changes made:

kate_after

Bali10050 commented 1 week ago

WOW! Nice work!

Bali10050 commented 1 week ago

Does kstyle/lightlyblurhelper.cpp contain any new changes, or is it just the remains of #31?

DeltaCopy commented 1 week ago

Aligned the code with how it set inside Breeze, Brise and Klassy.

    bool BlurHelper::eventFilter(QObject* object, QEvent* event)
    {
        switch (event->type()) {
            case QEvent::Hide:
            case QEvent::Show:
            case QEvent::Resize:
            {
                // cast to widget and check
                QWidget* widget(qobject_cast(object));

                if (!widget) <-- removed the || !widget->isWindow()
                    break;

                update(widget);
                break;
            }

            default: break;
        }

        // never eat events
        return false;
    }

This was the root of the problem, and it is now removed.

if( widget->palette().color( QPalette::Window ).alpha() < 255 )
     return roundedRegion(rect, StyleConfigData::cornerRadius(), false, false, true, true);
Bali10050 commented 1 week ago

532779d fixed the blur, and this removes it.

With the aligned code: Screenshot_20241115_205031

With 532779d: Screenshot_20241115_204448

Also, I think it's time to close #29

mashrit commented 23 hours ago

how did you get system setting to be transparent, mine doesn't do that

Screenshot_20241115_205031

Screenshot_20241115_204448

Bali10050 commented 23 hours ago

Hi @mashrit!

We use the Glassly-Darker color scheme for testing. I can't see the screenshots you included, but if you're making a color scheme, I can give you a more detailed answer.

mashrit commented 20 hours ago

We use the Glassly-Darker color scheme for testing.

strange glassly-darker does not seem to be transparent and glassly is transparent but the systemsettings is not.

I can't see the screenshots you included,

I had just quoted your screenshots.

but if you're making a color scheme, I can give you a more detailed answer.

not making a colour scheme, more like modifying an existing one

Bali10050 commented 20 hours ago

Have you tried restarting the systemsettings after applying the theme?

Before restart:

Screenshot_20241123_172542

After restart:

Screenshot_20241123_172552

mashrit commented 20 hours ago

yes,

before restart image

after restart image

Bali10050 commented 13 hours ago

What os are you using? Also, do you have any modifications that could be relevant? Is this wayland or x11?

mashrit commented 8 hours ago

i am using endeavouros wayland i do not of any modifications, but what i know is that the front of systemsettings is transparent, it is just that a background is drawn behind it

https://github.com/user-attachments/assets/86b375c3-5b5f-416d-a6fb-43ffaa9e5bde